Introduce a code stub version of Array.prototype.push

Introduce a code stub version of Array.prototype.push

This roughly doubles performance for generic Array.prototype.push.

BUG=

Committed: https://crrev.com/1134688cedecfdc35808d48fbdfeda49450cb618
Cr-Commit-Position: refs/heads/master@{#34987}

[Toon Verwaest, 2016-03-18 13:43:48]

Description was changed from

==========
Move Runtime_ArrayPush to builtins.cc to share code.

BUG=
==========

to

==========
Introduce a code stub version of Array.prototype.push

This roughly doubles performance for generic Array.prototype.push.

BUG=
==========

[Jakob Kummerow, 2016-03-21 15:12:50]

jkummerow@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Jakob Kummerow, 2016-03-21 15:12:51]

Looks good, just nits.

https://codereview.chromium.org/1816553002/diff/60001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):

https://codereview.chromium.org/1816553002/diff/60001/src/code-stubs-hydrogen...
src/code-stubs-hydrogen.cc:827: HValue* bit =
AddUncasted<HBitwise>(Token::BIT_AND, bit_field2, mask);
nit: call it "bits", could be more than one.

https://codereview.chromium.org/1816553002/diff/60001/src/code-stubs-hydrogen...
src/code-stubs-hydrogen.cc:861: // only default named properties on arrays. It's
nonconfigurable, hence is
nit: s/properties/property/

https://codereview.chromium.org/1816553002/diff/60001/src/code-stubs-hydrogen...
src/code-stubs-hydrogen.cc:872: IfBuilder writable(this);
nit: this should be called "readonly" (to make the line "readonly.ThenDeopt"
meaningful).

https://codereview.chromium.org/1816553002/diff/60001/src/code-stubs-hydrogen...
src/code-stubs-hydrogen.cc:899: instance_type, Add<HConstant>(JS_VALUE_TYPE),
Token::LTE);
This looks like a use case for the recently introduced
LAST_CUSTOM_ELEMENTS_RECEIVER, no?

https://codereview.chromium.org/1816553002/diff/60001/src/code-stubs-hydrogen...
src/code-stubs-hydrogen.cc:909:
no_elements.ElseDeopt(Deoptimizer::kFastArrayPushFailed);
nit: you could also use IfNot/ThenDeopt. Up to you.

https://codereview.chromium.org/1816553002/diff/60001/src/code-stubs-hydrogen...
src/code-stubs-hydrogen.cc:917: Add<HLoadNamedField>(map, nullptr,
HObjectAccess::ForMapBitField2());
This is duplicated from line 823. Suggestion: hoist the bitfield2 load to line
818 and re-use it for the check.

https://codereview.chromium.org/1816553002/diff/60001/src/code-stubs-hydrogen...
src/code-stubs-hydrogen.cc:920: IfBuilder is_smi(this);
nit: I'd prefer the name "has_smi_elements".

https://codereview.chromium.org/1816553002/diff/60001/src/code-stubs-hydrogen...
src/code-stubs-hydrogen.cc:922: kind, Add<HConstant>(FAST_HOLEY_SMI_ELEMENTS),
Token::LTE);
nit: a comment and a check would be nice, roughly:

// Comparing with Token::LTE covers both packed and holey smi elements.
STATIC_ASSERT(FAST_SMI_ELEMENTS < FAST_HOLEY_SMI_ELEMENTS);

and corresponding checks further down:
STATIC_ASSERT(FAST_ELEMENTS < FAST_HOLEY_ELEMENTS);
STATIC_ASSERT(FAST_DOUBLE_ELEMENTS > FAST_HOLEY_ELEMENTS);

https://codereview.chromium.org/1816553002/diff/60001/src/code-stubs-hydrogen...
src/code-stubs-hydrogen.cc:932: IfBuilder is_object(this);
nit: has_object_elements

[Toon Verwaest, 2016-03-22 08:51:14]

Rebased in 7 (to get LAST_CUSTOM_ELEMENTS_RECEIVER), addressed comments in 8.

[Toon Verwaest, 2016-03-22 09:01:45]

Addressed comments, ptal again. Rebased to get LAST_CUSTOM_ELEMENTS_RECEIVER

[Jakob Kummerow, 2016-03-22 12:27:04]

lgtm

[Toon Verwaest, 2016-03-22 12:27:30]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2016-03-22 12:27:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1816553002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1816553002/140001

[commit-bot: I haz the power, 2016-03-22 12:50:58]

Description was changed from

==========
Introduce a code stub version of Array.prototype.push

This roughly doubles performance for generic Array.prototype.push.

BUG=
==========

to

==========
Introduce a code stub version of Array.prototype.push

This roughly doubles performance for generic Array.prototype.push.

BUG=
==========

[commit-bot: I haz the power, 2016-03-22 12:50:59]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-03-22 12:51:44]

Description was changed from

==========
Introduce a code stub version of Array.prototype.push

This roughly doubles performance for generic Array.prototype.push.

BUG=
==========

to

==========
Introduce a code stub version of Array.prototype.push

This roughly doubles performance for generic Array.prototype.push.

BUG=

Committed: https://crrev.com/1134688cedecfdc35808d48fbdfeda49450cb618
Cr-Commit-Position: refs/heads/master@{#34987}
==========

[commit-bot: I haz the power, 2016-03-22 12:51:45]

Patchset 8 (id:??) landed as
https://crrev.com/1134688cedecfdc35808d48fbdfeda49450cb618
Cr-Commit-Position: refs/heads/master@{#34987}