src/objects-inl.h - Issue 1816553002: Introduce a code stub version of Array.prototype.push

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 1816553002: Introduce a code stub version of Array.prototype.push (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index 619fb778ecd637d7f1a960460644c6550d7353b6..be05866a52f8bf7fb8ed4012a7f85a612e1e33df 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -5813,7 +5813,7 @@ bool Script::HasValidSource() {

void SharedFunctionInfo::DontAdaptArguments() {

- DCHECK(code()->kind() == Code::BUILTIN);

+ DCHECK(code()->kind() == Code::BUILTIN || code()->kind() == Code::STUB);

set_internal_formal_parameter_count(kDontAdaptArgumentsSentinel);

}

« no previous file with comments | « src/objects.h ('k') | src/runtime/runtime.h » ('j') | no next file with comments »