Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 181653006: Remove testRunner.display() from most compositing/ tests (Closed)

Created:
6 years, 9 months ago by enne (OOO)
Modified:
6 years, 9 months ago
Reviewers:
jamesr
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

Remove testRunner.display() from most compositing/ tests BUG=345027 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168066

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : \tableflip{^M} #

Patch Set 6 : Remove problematic video test #

Patch Set 7 : Revert change to plugin test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+383 lines, -402 lines) Patch
M LayoutTests/compositing/animation/state-at-end-event-transform-layer.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/clip-change.html View 2 chunks +13 lines, -8 lines 0 comments Download
M LayoutTests/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html View 2 chunks +12 lines, -7 lines 0 comments Download
M LayoutTests/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html View 2 chunks +13 lines, -9 lines 0 comments Download
M LayoutTests/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html View 2 chunks +13 lines, -9 lines 0 comments Download
M LayoutTests/compositing/geometry/foreground-offset-change.html View 2 chunks +9 lines, -5 lines 0 comments Download
M LayoutTests/compositing/geometry/limit-layer-bounds-transformed-overflow.html View 1 chunk +1 line, -6 lines 0 comments Download
M LayoutTests/compositing/geometry/partial-layout-update.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite.html View 2 chunks +8 lines, -7 lines 0 comments Download
M LayoutTests/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite.html View 2 chunks +8 lines, -7 lines 0 comments Download
M LayoutTests/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite.html View 2 chunks +8 lines, -7 lines 0 comments Download
M LayoutTests/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite.html View 2 chunks +8 lines, -7 lines 0 comments Download
M LayoutTests/compositing/gestures/gesture-tapHighlight-simple-cancel.html View 2 chunks +6 lines, -5 lines 0 comments Download
M LayoutTests/compositing/iframes/become-composited-nested-iframes.html View 2 chunks +6 lines, -7 lines 0 comments Download
M LayoutTests/compositing/iframes/become-overlapped-iframe.html View 1 chunk +5 lines, -12 lines 0 comments Download
M LayoutTests/compositing/iframes/connect-compositing-iframe.html View 2 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/compositing/iframes/connect-compositing-iframe-delayed.html View 2 chunks +9 lines, -9 lines 0 comments Download
M LayoutTests/compositing/iframes/connect-compositing-iframe2.html View 2 chunks +8 lines, -8 lines 0 comments Download
M LayoutTests/compositing/iframes/connect-compositing-iframe3.html View 2 chunks +8 lines, -8 lines 0 comments Download
M LayoutTests/compositing/iframes/enter-compositing-iframe.html View 2 chunks +5 lines, -3 lines 0 comments Download
M LayoutTests/compositing/iframes/iframe-resize.html View 1 chunk +4 lines, -13 lines 0 comments Download
M LayoutTests/compositing/iframes/iframe-size-to-zero.html View 3 chunks +8 lines, -13 lines 0 comments Download
M LayoutTests/compositing/iframes/iframe-src-change.html View 3 chunks +10 lines, -9 lines 0 comments Download
M LayoutTests/compositing/iframes/invisible-nested-iframe-hide.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/compositing/iframes/invisible-nested-iframe-show.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/compositing/iframes/leave-compositing-iframe.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/compositing/iframes/overlapped-iframe.html View 1 chunk +3 lines, -9 lines 0 comments Download
M LayoutTests/compositing/iframes/overlapped-iframe-iframe.html View 1 chunk +3 lines, -10 lines 0 comments Download
M LayoutTests/compositing/iframes/overlapped-nested-iframes.html View 1 chunk +4 lines, -14 lines 0 comments Download
M LayoutTests/compositing/iframes/repaint-after-losing-scrollbars.html View 3 chunks +6 lines, -4 lines 0 comments Download
M LayoutTests/compositing/iframes/resources/fixed-position-subframe.html View 2 chunks +9 lines, -4 lines 0 comments Download
M LayoutTests/compositing/iframes/resources/scrollgrandchild-inner.html View 2 chunks +7 lines, -6 lines 0 comments Download
M LayoutTests/compositing/iframes/scrolling-iframe.html View 2 chunks +3 lines, -6 lines 0 comments Download
M LayoutTests/compositing/img-layer-grow.html View 2 chunks +3 lines, -4 lines 0 comments Download
M LayoutTests/compositing/layer-creation/fixed-position-out-of-view-positioning.html View 1 chunk +3 lines, -4 lines 0 comments Download
M LayoutTests/compositing/layer-creation/should-invoke-deferred-compositing.html View 2 chunks +11 lines, -7 lines 0 comments Download
M LayoutTests/compositing/overflow/content-gains-scrollbars.html View 2 chunks +6 lines, -5 lines 0 comments Download
M LayoutTests/compositing/overflow/content-loses-scrollbars.html View 2 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents.html View 2 chunks +2 lines, -3 lines 0 comments Download
M LayoutTests/compositing/overflow/iframe-nested-scroll-children.html View 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/compositing/overflow/iframe-scroll-children.html View 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/compositing/overflow/overflow-scrollbar-layers.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer.html View 3 chunks +2 lines, -4 lines 0 comments Download
M LayoutTests/compositing/overflow/repaint-after-losing-scrollbars.html View 2 chunks +7 lines, -4 lines 0 comments Download
M LayoutTests/compositing/repaint/fixed-pos-inside-composited-intermediate-layer.html View 3 chunks +13 lines, -7 lines 0 comments Download
M LayoutTests/compositing/repaint/fixed-pos-with-composited-child.html View 3 chunks +13 lines, -7 lines 0 comments Download
M LayoutTests/compositing/repaint/newly-composited-on-scroll.html View 2 chunks +8 lines, -11 lines 0 comments Download
M LayoutTests/compositing/repaint/newly-composited-repaint-rect.html View 2 chunks +3 lines, -5 lines 0 comments Download
M LayoutTests/compositing/repaint/page-scale-repaint.html View 1 chunk +8 lines, -3 lines 0 comments Download
M LayoutTests/compositing/repaint/requires-backing-repaint.html View 2 chunks +3 lines, -5 lines 0 comments Download
M LayoutTests/compositing/repaint/transform-style-change.html View 1 chunk +8 lines, -7 lines 0 comments Download
M LayoutTests/compositing/rtl/rtl-overflow-invalidation.html View 2 chunks +10 lines, -5 lines 0 comments Download
M LayoutTests/compositing/rubberbanding/transform-overhang-size-change.html View 1 chunk +6 lines, -2 lines 0 comments Download
D LayoutTests/compositing/scroll-painted-composited-content.html View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/compositing/scroll-painted-composited-content-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/compositing/squashing/add-remove-squashed-layers.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/squashing/squash-above-fixed-1.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/squashing/squash-above-fixed-2.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/squashing/squash-above-fixed-3.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/squashing/squash-onto-nephew.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/squashing/squash-onto-transform-backing.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/squashing/squash-simple.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/squashing/squash-three-layers.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/squashing/squash-transform.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/squashing/squash-transform-repainting-child.html View 3 chunks +12 lines, -3 lines 0 comments Download
M LayoutTests/compositing/squashing/squash-transform-repainting-transformed-child.html View 3 chunks +12 lines, -3 lines 0 comments Download
M LayoutTests/compositing/squashing/squashed-layer-loses-graphicslayer.html View 4 chunks +11 lines, -3 lines 0 comments Download
M LayoutTests/compositing/squashing/squashed-repaints.html View 4 chunks +11 lines, -3 lines 0 comments Download
M LayoutTests/compositing/video-frame-size-change.html View 1 chunk +3 lines, -4 lines 0 comments Download
M LayoutTests/compositing/video-page-visibility.html View 2 chunks +5 lines, -4 lines 0 comments Download
A LayoutTests/resources/run-after-display.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (0 generated)
enne (OOO)
testRunner.display() count: 197 -> 117 These are all the easy cases in compositing/. https://codereview.chromium.org/181653006/diff/1/LayoutTests/compositing/scroll-painted-composited-content.html File ...
6 years, 9 months ago (2014-02-27 00:09:14 UTC) #1
jamesr
lgtm!
6 years, 9 months ago (2014-02-27 00:12:00 UTC) #2
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-02-27 18:44:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/181653006/40001
6 years, 9 months ago (2014-02-27 18:46:43 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-27 18:47:31 UTC) #5
commit-bot: I haz the power
Failed to apply patch for LayoutTests/compositing/video/video-with-invalid-source.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-02-27 18:47:31 UTC) #6
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-02-27 19:07:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/181653006/60001
6 years, 9 months ago (2014-02-27 19:07:54 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-27 19:08:15 UTC) #9
commit-bot: I haz the power
Failed to apply patch for LayoutTests/compositing/video/video-with-invalid-source.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-02-27 19:08:16 UTC) #10
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-02-27 19:13:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/181653006/80001
6 years, 9 months ago (2014-02-27 19:13:49 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-27 19:14:08 UTC) #13
commit-bot: I haz the power
Failed to apply patch for LayoutTests/compositing/video/video-with-invalid-source.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-02-27 19:14:08 UTC) #14
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-02-27 19:16:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/181653006/100001
6 years, 9 months ago (2014-02-27 19:17:02 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-27 21:02:54 UTC) #17
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=20357
6 years, 9 months ago (2014-02-27 21:02:55 UTC) #18
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-02-27 21:13:25 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/181653006/100001
6 years, 9 months ago (2014-02-27 21:13:31 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-27 22:56:36 UTC) #21
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=20372
6 years, 9 months ago (2014-02-27 22:56:38 UTC) #22
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-02-27 22:59:46 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/181653006/120001
6 years, 9 months ago (2014-02-27 23:00:16 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/181653006/120001
6 years, 9 months ago (2014-02-28 01:07:41 UTC) #25
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 01:14:22 UTC) #26
Message was sent while issue was closed. 
Change committed as 168066

Powered by Google App Engine
This is Rietveld 408576698