LayoutTests/compositing/iframes/repaint-after-losing-scrollbars.html - Issue 181653006: Remove testRunner.display() from most compositing/ tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/compositing/iframes/repaint-after-losing-scrollbars.html

Issue 181653006: Remove testRunner.display() from most compositing/ tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Revert change to plugin test Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/compositing/iframes/overlapped-nested-iframes.html ('k') | LayoutTests/compositing/iframes/resources/fixed-position-subframe.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/compositing/iframes/repaint-after-losing-scrollbars.html

diff --git a/LayoutTests/compositing/iframes/repaint-after-losing-scrollbars.html b/LayoutTests/compositing/iframes/repaint-after-losing-scrollbars.html

index 832178f0fd374b79fe7e29044fa57b732a9aadd7..a3b2f7c75fd2d8ea40f1975fccef719bad4d8edf 100644

--- a/LayoutTests/compositing/iframes/repaint-after-losing-scrollbars.html

+++ b/LayoutTests/compositing/iframes/repaint-after-losing-scrollbars.html

@@ -1,4 +1,5 @@

<!DOCTYPE html>

+<script src="../../resources/run-after-display.js"></script>

<style>

.composited {

@@ -26,6 +27,8 @@ function finishTest() {

document.getElementById("horizontal").contentDocument.body.classList.remove("wide"); // middle iframe loses a horizontal scrollbar

document.getElementById("both").contentDocument.body.classList.remove("wide"); // bottom iframe loses both

document.getElementById("both").contentDocument.body.classList.remove("tall"); // bottom iframe loses both

+ if (window.testRunner)

+ testRunner.notifyDone();

}

function test() {

@@ -35,9 +38,8 @@ function test() {

document.getElementById("both").contentDocument.body.classList.add("tall"); // vertical and horizontal scrollbars

if (window.testRunner) {

testRunner.dumpAsTextWithPixelResults();

- testRunner.display(); // Paint once with all overflow controls visible.

- finishTest();

- } else

- window.setTimeout(finishTest, 5000);

+ testRunner.waitUntilDone();

+ }

+ runAfterDisplay(finishTest);

}

</script>