Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(71)

Issue 1816473002: Add layout tests to check that a FetchEvent includes the right headers (Closed)

Created:
2 years, 11 months ago by tyoshino (SeeGerritForStatus)
Modified:
2 years, 7 months ago
Reviewers:
Mike West, yhirano
CC:
blink-reviews, chromium-reviews, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add layout tests to check that a FetchEvent includes the right headers BUG=595993 R=yhirano,mkwst Committed: https://crrev.com/c9e3bae7bb5eb30328b5a202b8dcc2556de130b0 Cr-Commit-Position: refs/heads/master@{#406242}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Add cross origin test #

Patch Set 4 : Factor out common code #

Patch Set 5 : Add TODO #

Total comments: 8

Patch Set 6 : Addressed #7 #

Patch Set 7 : Use const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html View 1 2 3 4 5 6 1 chunk +28 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-event-test-worker.js View 1 2 3 4 5 6 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html View 1 2 3 4 5 2 chunks +58 lines, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
tyoshino (SeeGerritForStatus)
mkwst: Please check if it's fine that upgrade-insecure-requests is exposed to SW. If not, I'll ...
2 years, 7 months ago (2016-07-19 05:56:29 UTC) #2
Mike West
https://codereview.chromium.org/1816473002/diff/80001/third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html File third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html (right): https://codereview.chromium.org/1816473002/diff/80001/third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html#newcode28 third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html:28: ["accept", "upgrade-insecure-requests", "user-agent"], This is a navigational request, right? ...
2 years, 7 months ago (2016-07-19 07:22:13 UTC) #5
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/1816473002/diff/80001/third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html File third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html (right): https://codereview.chromium.org/1816473002/diff/80001/third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html#newcode28 third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html:28: ["accept", "upgrade-insecure-requests", "user-agent"], On 2016/07/19 07:22:13, Mike West wrote: ...
2 years, 7 months ago (2016-07-19 07:26:08 UTC) #6
yhirano
LGTM I prefer const / let to var in new code, but it's optional. https://codereview.chromium.org/1816473002/diff/80001/third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html ...
2 years, 7 months ago (2016-07-19 07:28:40 UTC) #7
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/1816473002/diff/80001/third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html File third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html (right): https://codereview.chromium.org/1816473002/diff/80001/third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html#newcode22 third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html:22: for (var i in headers) { On 2016/07/19 07:28:40, ...
2 years, 7 months ago (2016-07-19 08:50:31 UTC) #8
tyoshino (SeeGerritForStatus)
On 2016/07/19 07:28:40, yhirano wrote: > I prefer const / let to var in new ...
2 years, 7 months ago (2016-07-19 08:52:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/1816473002/120001
2 years, 7 months ago (2016-07-19 08:53:32 UTC) #13
commit-bot: I haz the power
Committed patchset #7 (id:120001)
2 years, 7 months ago (2016-07-19 11:02:36 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
2 years, 7 months ago (2016-07-19 11:02:41 UTC) #16
commit-bot: I haz the power
2 years, 7 months ago (2016-07-19 11:03:50 UTC) #18
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/c9e3bae7bb5eb30328b5a202b8dcc2556de130b0
Cr-Commit-Position: refs/heads/master@{#406242}

Powered by Google App Engine
This is Rietveld 408576698