Add layout tests to check that a FetchEvent includes the right headers

Add layout tests to check that a FetchEvent includes the right headers

BUG=595993
R=yhirano,mkwst

Committed: https://crrev.com/c9e3bae7bb5eb30328b5a202b8dcc2556de130b0
Cr-Commit-Position: refs/heads/master@{#406242}

[tyoshino (SeeGerritForStatus), 2016-07-19 05:56:27]

tyoshino@chromium.org changed reviewers:
+ mkwst@chromium.org, yhirano@chromium.org

[tyoshino (SeeGerritForStatus), 2016-07-19 05:56:29]

mkwst: Please check if it's fine that upgrade-insecure-requests is exposed to
SW. If not, I'll add some TODO for you.

[tyoshino (SeeGerritForStatus), 2016-07-19 05:56:48]

Description was changed from

==========
Add layout tests to check that a FetchEvent includes the right headers

BUG=
==========

to

==========
Add layout tests to check that a FetchEvent includes the right headers

BUG=none
==========

[tyoshino (SeeGerritForStatus), 2016-07-19 05:57:57]

Description was changed from

==========
Add layout tests to check that a FetchEvent includes the right headers

BUG=none
==========

to

==========
Add layout tests to check that a FetchEvent includes the right headers

BUG=595993
==========

[Mike West, 2016-07-19 07:22:13]

https://codereview.chromium.org/1816473002/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html
(right):

https://codereview.chromium.org/1816473002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html:28:
["accept", "upgrade-insecure-requests", "user-agent"],
This is a navigational request, right? If so, LGTM.

[tyoshino (SeeGerritForStatus), 2016-07-19 07:26:08]

https://codereview.chromium.org/1816473002/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html
(right):

https://codereview.chromium.org/1816473002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html:28:
["accept", "upgrade-insecure-requests", "user-agent"],
On 2016/07/19 07:22:13, Mike West wrote:
> This is a navigational request, right? If so, LGTM.

Right. It's listing what the request for loading the iframe's main resource
included.

[yhirano, 2016-07-19 07:28:40]

LGTM

I prefer const / let to var in new code, but it's optional.

https://codereview.chromium.org/1816473002/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html
(right):

https://codereview.chromium.org/1816473002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html:22: for
(var i in headers) {
Can we use the destructuring syntax?

for (const [name, value] of headers) { header_names.push(name); }

Or we could even use |map|:

const header_names = headers.map(([name, value]) => name).sort();

https://codereview.chromium.org/1816473002/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-event-test-worker.js
(right):

https://codereview.chromium.org/1816473002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-event-test-worker.js:78:
event.respondWith(new Response(JSON.stringify(headers)));
You can use Array.from(event.request.headers).

https://codereview.chromium.org/1816473002/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html
(right):

https://codereview.chromium.org/1816473002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html:58:
function get_sorted_header_name_list(headers) {
ditto as fetch-event.html

[tyoshino (SeeGerritForStatus), 2016-07-19 08:50:31]

https://codereview.chromium.org/1816473002/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html
(right):

https://codereview.chromium.org/1816473002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html:22: for
(var i in headers) {
On 2016/07/19 07:28:40, yhirano wrote:
> Can we use the destructuring syntax?
> 
> for (const [name, value] of headers) { header_names.push(name); }
> 
> Or we could even use |map|:
> 
> const header_names = headers.map(([name, value]) => name).sort();

Done.

https://codereview.chromium.org/1816473002/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-event-test-worker.js
(right):

https://codereview.chromium.org/1816473002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-event-test-worker.js:78:
event.respondWith(new Response(JSON.stringify(headers)));
On 2016/07/19 07:28:40, yhirano wrote:
> You can use Array.from(event.request.headers).

Done.

https://codereview.chromium.org/1816473002/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html
(right):

https://codereview.chromium.org/1816473002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html:58:
function get_sorted_header_name_list(headers) {
On 2016/07/19 07:28:40, yhirano wrote:
> ditto as fetch-event.html

Done.

[tyoshino (SeeGerritForStatus), 2016-07-19 08:52:43]

On 2016/07/19 07:28:40, yhirano wrote:
> I prefer const / let to var in new code, but it's optional.

Fixed

[tyoshino (SeeGerritForStatus), 2016-07-19 08:52:55]

Description was changed from

==========
Add layout tests to check that a FetchEvent includes the right headers

BUG=595993
==========

to

==========
Add layout tests to check that a FetchEvent includes the right headers

BUG=595993
R=yhirano,mkwst
==========

[tyoshino (SeeGerritForStatus), 2016-07-19 08:53:07]

The CQ bit was checked by tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2016-07-19 08:53:08]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org,
yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/1816473002/#ps120001
(title: "Use const")

[commit-bot: I haz the power, 2016-07-19 08:53:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 11:02:35]

Description was changed from

==========
Add layout tests to check that a FetchEvent includes the right headers

BUG=595993
R=yhirano,mkwst
==========

to

==========
Add layout tests to check that a FetchEvent includes the right headers

BUG=595993
R=yhirano,mkwst
==========

[commit-bot: I haz the power, 2016-07-19 11:02:36]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-07-19 11:02:41]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-19 11:03:49]

Description was changed from

==========
Add layout tests to check that a FetchEvent includes the right headers

BUG=595993
R=yhirano,mkwst
==========

to

==========
Add layout tests to check that a FetchEvent includes the right headers

BUG=595993
R=yhirano,mkwst

Committed: https://crrev.com/c9e3bae7bb5eb30328b5a202b8dcc2556de130b0
Cr-Commit-Position: refs/heads/master@{#406242}
==========

[commit-bot: I haz the power, 2016-07-19 11:03:50]

Patchset 7 (id:??) landed as
https://crrev.com/c9e3bae7bb5eb30328b5a202b8dcc2556de130b0
Cr-Commit-Position: refs/heads/master@{#406242}