Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Issue 1816413002: Make ExistsMulti return a BoolList (Closed)

Created:
4 years, 9 months ago by iannucci
Modified:
4 years, 9 months ago
Reviewers:
dnj, estaab, nodir
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/gae@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Make ExistsMulti return a BoolList BoolList has some convenience functions (e.g. to check if Any() or All() are set.). It's compatible with current uses of ExistsMulti. R=dnj@chromium.org, estaab@chromium.org, nodir@chromium.org BUG=550684 Committed: https://github.com/luci/gae/commit/ecb855a03c1c253984cab51cace564d204d349cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -3 lines) Patch
M service/datastore/datastore.go View 1 chunk +2 lines, -2 lines 0 comments Download
M service/datastore/datastore_test.go View 1 chunk +18 lines, -0 lines 0 comments Download
M service/datastore/interface.go View 2 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
iannucci
4 years, 9 months ago (2016-03-22 02:10:07 UTC) #1
dnj
lgtm
4 years, 9 months ago (2016-03-22 16:48:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816413002/1
4 years, 9 months ago (2016-03-22 18:41:02 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 18:46:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/ecb855a03c1c253984cab51cace564d204d349cd

Powered by Google App Engine
This is Rietveld 408576698