service/datastore/datastore.go - Issue 1816413002: Make ExistsMulti return a BoolList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: service/datastore/datastore.go

Issue 1816413002: Make ExistsMulti return a BoolList (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: service/datastore/datastore.go

diff --git a/service/datastore/datastore.go b/service/datastore/datastore.go

index 0389ab8914415b197f88abc87911eb05541587b9..306df526153e401e75e64126194539ade80c206c 100644

--- a/service/datastore/datastore.go

+++ b/service/datastore/datastore.go

@@ -245,9 +245,9 @@ func isOkType(t reflect.Type) error {

return nil

}

-func (d *datastoreImpl) ExistsMulti(keys []*Key) ([]bool, error) {

+func (d *datastoreImpl) ExistsMulti(keys []*Key) (BoolList, error) {

lme := errors.NewLazyMultiError(len(keys))

- ret := make([]bool, len(keys))

+ ret := make(BoolList, len(keys))

i := 0

err := d.RawInterface.GetMulti(keys, nil, func(_ PropertyMap, err error) error {

if err == nil {

« no previous file with comments | « no previous file | service/datastore/datastore_test.go » ('j') | no next file with comments »