Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 181633002: Apply .globalAlpha to SVG-images painted using <canvas> drawImage() (Closed)

Created:
6 years, 10 months ago by fs
Modified:
6 years, 10 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, ed+blinkwatch_opera.com, Rik, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, rwlbuis, Justin Novosad
Visibility:
Public.

Description

Apply .globalAlpha to SVG-images painted using <canvas> drawImage() BUG=261177 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167970

Patch Set 1 #

Patch Set 2 : Update TestExpectations. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -4 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/svg/canvas/canvas-draw-image-globalalpha.html View 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/svg/canvas/canvas-draw-image-globalalpha-expected.html View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 1 2 2 chunks +6 lines, -4 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
fs
6 years, 10 months ago (2014-02-26 17:10:16 UTC) #1
pdr.
On 2014/02/26 17:10:16, fs wrote: LGTM
6 years, 10 months ago (2014-02-26 19:00:25 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 10 months ago (2014-02-26 19:00:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/181633002/40001
6 years, 10 months ago (2014-02-26 19:01:18 UTC) #4
Stephen Chennney
When this commit, or before, go in and change the code to use getNormalizedAlpha and ...
6 years, 10 months ago (2014-02-26 19:26:42 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-27 01:50:55 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=29212
6 years, 10 months ago (2014-02-27 01:50:56 UTC) #7
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 10 months ago (2014-02-27 01:54:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/181633002/40001
6 years, 10 months ago (2014-02-27 01:55:13 UTC) #9
commit-bot: I haz the power
Change committed as 167970
6 years, 10 months ago (2014-02-27 03:30:15 UTC) #10
fs
On 2014/02/26 19:26:42, Stephen Chenney wrote: > When this commit, or before, go in and ...
6 years, 10 months ago (2014-02-27 08:40:02 UTC) #11
fs
6 years, 10 months ago (2014-02-27 09:06:58 UTC) #12
Message was sent while issue was closed.
On 2014/02/27 08:40:02, fs wrote:
> On 2014/02/26 19:26:42, Stephen Chenney wrote:
> > When this commit, or before, go in and change the code to use
> getNormalizedAlpha
> > and divide by 255.0. Any minute now GraphicsContext will be storing alpha as
> an
> > int as that is how it is almost universally used.
> 
> Roger. Will do.

https://codereview.chromium.org/182853002/

Powered by Google App Engine
This is Rietveld 408576698