Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1816173003: Merge M50: "Drop media session on playback error; avoids idle suspension." (Closed)

Created:
4 years, 9 months ago by DaleCurtis
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Merge M50: "Drop media session on playback error; avoids idle suspension." Avoids leaving a stale interactive session when the player is in the error state and also avoids idle suspension from running later and triggering an invalid state error. The pipeline has already released its resources internally when the error occurred so the idle suspension is not necessary. BUG=596157 Review URL: https://codereview.chromium.org/1815293003 Cr-Commit-Position: refs/heads/master@{#382137} (cherry picked from commit 60030663a474eb523aa9c958e5fe88fa844d8b79) Committed: https://chromium.googlesource.com/chromium/src/+/0a7d7379015541ad6356f2cb4d90be4614ca3135

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M media/blink/webmediaplayer_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
DaleCurtis
4 years, 9 months ago (2016-03-21 17:57:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0a7d7379015541ad6356f2cb4d90be4614ca3135.

Powered by Google App Engine
This is Rietveld 408576698