Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1815293003: Drop media session on playback error; avoids idle suspension. (Closed)

Created:
4 years, 9 months ago by DaleCurtis
Modified:
4 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop media session on playback error; avoids idle suspension. Avoids leaving a stale interactive session when the player is in the error state and also avoids idle suspension from running later and triggering an invalid state error. The pipeline has already released its resources internally when the error occurred so the idle suspension is not necessary. BUG=596157 Committed: https://crrev.com/60030663a474eb523aa9c958e5fe88fa844d8b79 Cr-Commit-Position: refs/heads/master@{#382137}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M media/blink/webmediaplayer_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
DaleCurtis
4 years, 9 months ago (2016-03-18 21:25:20 UTC) #2
sandersd (OOO until July 31)
lgtm
4 years, 9 months ago (2016-03-18 22:13:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815293003/1
4 years, 9 months ago (2016-03-18 22:17:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-19 00:28:44 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-19 00:30:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60030663a474eb523aa9c958e5fe88fa844d8b79
Cr-Commit-Position: refs/heads/master@{#382137}

Powered by Google App Engine
This is Rietveld 408576698