Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 18161004: [WIP] Remove unneeded JNI registrations. (Closed)

Created:
7 years, 5 months ago by Yaron
Modified:
6 years, 2 months ago
Reviewers:
bulach, Maria, Torne
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

[WIP] Remove unneeded JNI registrations. Rather than registering all jni bindings at startup, only get references to the class object for those files which require bindings. All others are satisfied by exporting symbols which can be found automatically by dalvik. Based on systrace, looks to be 10-30ms improvement but it's far less than std dev on cold start tests I've done. This is incomplete as it currently requires exporting all symbols. BUG=

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -7 lines) Patch
M base/android/jni_generator/jni_generator.py View 8 chunks +24 lines, -6 lines 1 comment Download
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Yaron
Not meant for real review but Maria was curious. As the CL description mentions, it ...
7 years, 5 months ago (2013-06-28 00:22:12 UTC) #1
bulach
this is very neat, I think we should go for it.. adding torne for his ...
7 years, 5 months ago (2013-06-28 00:45:53 UTC) #2
Torne
This looks pretty neat as long as we can sort the export issue and the ...
7 years, 5 months ago (2013-06-28 00:48:54 UTC) #3
bulach
7 years, 5 months ago (2013-06-28 00:53:24 UTC) #4
btw, in terms of size: we'll be able to remove the "kMethods" arrays, which
contains all method names... granted, it's a bit larger with the full package
name, but it shouldn't be too bad, I hope...

Powered by Google App Engine
This is Rietveld 408576698