Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1816063006: Increase default profiler depth (Closed)

Created:
4 years, 9 months ago by Cutch
Modified:
4 years, 9 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M runtime/vm/profiler.cc View 2 chunks +2 lines, -1 line 2 comments Download

Messages

Total messages: 7 (3 generated)
Cutch
4 years, 9 months ago (2016-03-22 16:44:25 UTC) #3
srdjan
lgtm https://codereview.chromium.org/1816063006/diff/1/runtime/vm/profiler.cc File runtime/vm/profiler.cc (right): https://codereview.chromium.org/1816063006/diff/1/runtime/vm/profiler.cc#newcode43 runtime/vm/profiler.cc:43: DEFINE_FLAG(int, max_profile_depth, kSampleSize * kMaxSamplesPerTick, Do you assert ...
4 years, 9 months ago (2016-03-22 16:59:56 UTC) #4
Cutch
https://codereview.chromium.org/1816063006/diff/1/runtime/vm/profiler.cc File runtime/vm/profiler.cc (right): https://codereview.chromium.org/1816063006/diff/1/runtime/vm/profiler.cc#newcode43 runtime/vm/profiler.cc:43: DEFINE_FLAG(int, max_profile_depth, kSampleSize * kMaxSamplesPerTick, On 2016/03/22 16:59:56, srdjan ...
4 years, 9 months ago (2016-03-22 22:18:29 UTC) #5
Cutch
4 years, 9 months ago (2016-03-22 22:18:49 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ea8a824912fbcfaf8c660d357ad5a1c8518a7daf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698