runtime/vm/profiler.cc - Issue 1816063006: Increase default profiler depth

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/profiler.cc

Issue 1816063006: Increase default profiler depth (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/profiler.cc

diff --git a/runtime/vm/profiler.cc b/runtime/vm/profiler.cc

index f0014f4765ba1852cffecbafd4b87d5b60e8a015..50669c1b7b0ef7143e4c2e8a2a0a217002a0279a 100644

--- a/runtime/vm/profiler.cc

+++ b/runtime/vm/profiler.cc

@@ -27,6 +27,7 @@

namespace dart {

static const intptr_t kSampleSize = 8;

+static const intptr_t kMaxSamplesPerTick = 4;

DECLARE_FLAG(bool, trace_profiler);

DEFINE_FLAG(bool, trace_profiled_isolates, false, "Trace profiled isolates.");

@@ -39,7 +40,7 @@ DEFINE_FLAG(bool, trace_profiled_isolates, false, "Trace profiled isolates.");

DEFINE_FLAG(int, profile_period, 1000,

"Time between profiler samples in microseconds. Minimum 50.");

#endif

-DEFINE_FLAG(int, max_profile_depth, kSampleSize,

+DEFINE_FLAG(int, max_profile_depth, kSampleSize * kMaxSamplesPerTick,

srdjan 2016/03/22 16:59:56 Do you assert somewhere that it does not go over 2

Cutch 2016/03/22 22:18:29 Yes, see SetSampleDepth which ensures it is in ran

"Maximum number stack frames walked. Minimum 1. Maximum 255.");

#if defined(USING_SIMULATOR)

DEFINE_FLAG(bool, profile_vm, true,

« no previous file with comments | « no previous file | no next file » | no next file with comments »