Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 1815893002: Merge M50: "Disable "pause-and-buffer" on Android, cancel suspended players." (Closed)

Created:
4 years, 9 months ago by DaleCurtis
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Merge M50: "Disable "pause-and-buffer" on Android, cancel suspended players." The Android MediaPlayer never supported "pause-and-buffer" so to avoid unexpected behavior on metered networks, disable this feature for WebMediaPlayerImpl as well. This also releases the network connection for suspended instances of WebMediaPlayerImpl. Due to "pause-and-buffer" on non-Android platforms only instances that the user has never interacted with (i.e. they have not played and then paused the player) will be released. On Android, all suspended players will lose their network connection after reaches the deferred state. BUG=594669 TEST=new unittests, verified connection is closed manually. Review URL: https://codereview.chromium.org/1798213002 Cr-Commit-Position: refs/heads/master@{#381280} (cherry picked from commit 37fe586e648a966438f0b26473155cba830d497e) Committed: https://chromium.googlesource.com/chromium/src/+/cec74ffcf0ffab45ec51ac48d49dda4489c88b04

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -19 lines) Patch
M media/blink/buffered_data_source.h View 2 chunks +12 lines, -8 lines 0 comments Download
M media/blink/buffered_data_source.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M media/blink/buffered_data_source_unittest.cc View 2 chunks +38 lines, -1 line 0 comments Download
M media/blink/multibuffer_data_source.h View 1 chunk +6 lines, -4 lines 0 comments Download
M media/blink/multibuffer_data_source.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M media/blink/multibuffer_data_source_unittest.cc View 2 chunks +42 lines, -1 line 0 comments Download
M media/blink/webmediaplayer_impl.cc View 4 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
DaleCurtis
4 years, 9 months ago (2016-03-19 00:20:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cec74ffcf0ffab45ec51ac48d49dda4489c88b04 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698