Disable "pause-and-buffer" on Android, cancel suspended players.

Disable "pause-and-buffer" on Android, cancel suspended players.

The Android MediaPlayer never supported "pause-and-buffer" so to
avoid unexpected behavior on metered networks, disable this feature
for WebMediaPlayerImpl as well.

This also releases the network connection for suspended instances
of WebMediaPlayerImpl. Due to "pause-and-buffer" on non-Android
platforms only instances that the user has never interacted with
(i.e. they have not played and then paused the player) will be
released. On Android, all suspended players will lose their
network connection after reaches the deferred state.

BUG=594669
TEST=new unittests, verified connection is closed manually.

Committed: https://crrev.com/37fe586e648a966438f0b26473155cba830d497e
Cr-Commit-Position: refs/heads/master@{#381280}

[hubbe, 2016-03-14 23:16:04]

hubbe@chromium.org changed reviewers:
+ hubbe@chromium.org

[hubbe, 2016-03-14 23:16:05]

https://codereview.chromium.org/1798213002/diff/1/media/blink/multibuffer_dat...
File media/blink/multibuffer_data_source_unittest.cc (right):

https://codereview.chromium.org/1798213002/diff/1/media/blink/multibuffer_dat...
media/blink/multibuffer_data_source_unittest.cc:1248: while (active_loader() &&
!active_loader()->deferred()) {
You probably want active_loader_allownull() here.
These kind of things would be easier to debug if we used CHECK instead of EXPECT
in the helper functions, as we would get backtraces...

[DaleCurtis, 2016-03-14 23:24:38]

PTAL. Thanks!

https://codereview.chromium.org/1798213002/diff/1/media/blink/multibuffer_dat...
File media/blink/multibuffer_data_source_unittest.cc (right):

https://codereview.chromium.org/1798213002/diff/1/media/blink/multibuffer_dat...
media/blink/multibuffer_data_source_unittest.cc:1248: while (active_loader() &&
!active_loader()->deferred()) {
On 2016/03/14 at 23:16:05, hubbe wrote:
> You probably want active_loader_allownull() here.
> These kind of things would be easier to debug if we used CHECK instead of
EXPECT in the helper functions, as we would get backtraces...

Thanks! That was the issue. True, unfortunately CHECK() kills the test harness.
Perhaps we should just be printing stack traces when EXPECT fails? Might get a
bit spammy though.

[hubbe, 2016-03-15 18:17:20]

lgtm

[DaleCurtis, 2016-03-15 18:19:03]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2016-03-15 18:19:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1798213002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1798213002/20001

[commit-bot: I haz the power, 2016-03-15 19:29:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-15 19:30:49]

Description was changed from

==========
Disable "pause-and-buffer" on Android, cancel suspended players.

The Android MediaPlayer never supported "pause-and-buffer" so to
avoid unexpected behavior on metered networks, disable this feature
for WebMediaPlayerImpl as well.

This also releases the network connection for suspended instances
of WebMediaPlayerImpl. Due to "pause-and-buffer" on non-Android
platforms only instances that the user has never interacted with
(i.e. they have not played and then paused the player) will be
released. On Android, all suspended players will lose their
network connection after reaches the deferred state.

BUG=594669
TEST=new unittests, verified connection is closed manually.
==========

to

==========
Disable "pause-and-buffer" on Android, cancel suspended players.

The Android MediaPlayer never supported "pause-and-buffer" so to
avoid unexpected behavior on metered networks, disable this feature
for WebMediaPlayerImpl as well.

This also releases the network connection for suspended instances
of WebMediaPlayerImpl. Due to "pause-and-buffer" on non-Android
platforms only instances that the user has never interacted with
(i.e. they have not played and then paused the player) will be
released. On Android, all suspended players will lose their
network connection after reaches the deferred state.

BUG=594669
TEST=new unittests, verified connection is closed manually.

Committed: https://crrev.com/37fe586e648a966438f0b26473155cba830d497e
Cr-Commit-Position: refs/heads/master@{#381280}
==========

[commit-bot: I haz the power, 2016-03-15 19:30:50]

Patchset 2 (id:??) landed as
https://crrev.com/37fe586e648a966438f0b26473155cba830d497e
Cr-Commit-Position: refs/heads/master@{#381280}