Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Issue 1815733003: Remove recently introduced FunctionType vm class by merging it into class Type. (Closed)

Created:
4 years, 9 months ago by regis
Modified:
4 years, 9 months ago
Reviewers:
rmacnak, srdjan, hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove recently introduced FunctionType vm class by merging it into class Type. Fix syntax used when printing function type with optional named parameters. Fix several issues discovered with cloning function types. R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/966aea003bd319f9577caa19756563365236a952

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+695 lines, -1165 lines) Patch
M runtime/lib/mirrors.cc View 5 chunks +14 lines, -13 lines 0 comments Download
M runtime/lib/type_patch.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/class_finalizer.h View 2 chunks +3 lines, -4 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 42 chunks +147 lines, -163 lines 0 comments Download
M runtime/vm/compiler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/exceptions.cc View 1 chunk +15 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/megamorphic_cache_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 16 chunks +33 lines, -120 lines 0 comments Download
M runtime/vm/object.cc View 1 39 chunks +427 lines, -657 lines 0 comments Download
M runtime/vm/object_service.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M runtime/vm/parser.cc View 10 chunks +16 lines, -21 lines 0 comments Download
M runtime/vm/precompiler.cc View 1 2 chunks +5 lines, -9 lines 0 comments Download
M runtime/vm/raw_object.h View 1 3 chunks +12 lines, -23 lines 0 comments Download
M runtime/vm/raw_object.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 chunk +0 lines, -77 lines 0 comments Download
M runtime/vm/snapshot.h View 3 chunks +0 lines, -3 lines 0 comments Download
M runtime/vm/snapshot.cc View 4 chunks +7 lines, -16 lines 0 comments Download
M runtime/vm/symbols.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
regis
4 years, 9 months ago (2016-03-18 21:58:24 UTC) #2
hausner
lgtm LGTM https://codereview.chromium.org/1815733003/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (left): https://codereview.chromium.org/1815733003/diff/1/runtime/vm/object.cc#oldcode15985 runtime/vm/object.cc:15985: Nit: keep this empty line.
4 years, 9 months ago (2016-03-21 20:59:18 UTC) #3
regis
Thanks! https://codereview.chromium.org/1815733003/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (left): https://codereview.chromium.org/1815733003/diff/1/runtime/vm/object.cc#oldcode15985 runtime/vm/object.cc:15985: On 2016/03/21 20:59:17, hausner wrote: > Nit: keep ...
4 years, 9 months ago (2016-03-21 21:07:09 UTC) #4
regis
Committed patchset #2 (id:20001) manually as 966aea003bd319f9577caa19756563365236a952 (presubmit successful).
4 years, 9 months ago (2016-03-21 21:09:02 UTC) #6
srdjan
4 years, 9 months ago (2016-03-21 21:39:30 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698