Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: runtime/vm/flow_graph_type_propagator.cc

Issue 1815733003: Remove recently introduced FunctionType vm class by merging it into class Type. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: address comment Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_type_propagator.cc
diff --git a/runtime/vm/flow_graph_type_propagator.cc b/runtime/vm/flow_graph_type_propagator.cc
index 7c83e391699f9a0f7fba33a0768aafdae2d186c9..d3242c9d672d3d5075ce52b6a5a33d1c0ffd6110 100644
--- a/runtime/vm/flow_graph_type_propagator.cc
+++ b/runtime/vm/flow_graph_type_propagator.cc
@@ -981,8 +981,7 @@ CompileType AllocateObjectInstr::ComputeType() const {
ASSERT(cls().id() == kClosureCid);
return CompileType(CompileType::kNonNullable,
kClosureCid,
- &FunctionType::ZoneHandle(
- closure_function().SignatureType()));
+ &Type::ZoneHandle(closure_function().SignatureType()));
}
// TODO(vegorov): Incorporate type arguments into the returned type.
return CompileType::FromCid(cls().id());
@@ -1009,8 +1008,9 @@ CompileType LoadFieldInstr::ComputeType() const {
const AbstractType* abstract_type = NULL;
if (Isolate::Current()->type_checks() &&
- type().HasResolvedTypeClass() &&
- !Field::IsExternalizableCid(Class::Handle(type().type_class()).id())) {
+ (type().IsFunctionType() ||
+ (type().HasResolvedTypeClass() &&
+ !Field::IsExternalizableCid(Class::Handle(type().type_class()).id())))) {
abstract_type = &type();
}
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698