Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1815693002: Don't serialize unnamed mixin applications. (Closed)

Created:
4 years, 9 months ago by Johnni Winther
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't serialize unnamed mixin applications. This change is needed to allow for per-library serialization. These elements should not be part of the element model, anyway. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/b4b67c3d2a136f4952e346d51d1088482c8f735d

Patch Set 1 #

Patch Set 2 : Handle cyclic class hierarchies. #

Total comments: 10

Patch Set 3 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+577 lines, -191 lines) Patch
M pkg/compiler/lib/src/dart_types.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/common.dart View 1 chunk +34 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 2 chunks +1 line, -26 lines 0 comments Download
M pkg/compiler/lib/src/ordered_typeset.dart View 1 2 2 chunks +71 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 1 4 chunks +9 lines, -39 lines 0 comments Download
M pkg/compiler/lib/src/serialization/element_serialization.dart View 5 chunks +30 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/serialization/impact_serialization.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/keys.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 2 13 chunks +396 lines, -82 lines 0 comments Download
M pkg/compiler/lib/src/serialization/serialization.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/serialization_test.dart View 1 2 2 chunks +27 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 9 months ago (2016-03-18 17:34:56 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1815693002/diff/20001/pkg/compiler/lib/src/ordered_typeset.dart File pkg/compiler/lib/src/ordered_typeset.dart (right): https://codereview.chromium.org/1815693002/diff/20001/pkg/compiler/lib/src/ordered_typeset.dart#newcode166 pkg/compiler/lib/src/ordered_typeset.dart:166: if (_objectType == null) { it's a bit ...
4 years, 9 months ago (2016-03-18 20:23:13 UTC) #3
Johnni Winther
Committed patchset #3 (id:40001) manually as b4b67c3d2a136f4952e346d51d1088482c8f735d (presubmit successful).
4 years, 8 months ago (2016-03-29 08:26:36 UTC) #5
Johnni Winther
4 years, 8 months ago (2016-03-29 08:28:53 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1815693002/diff/20001/pkg/compiler/lib/src/or...
File pkg/compiler/lib/src/ordered_typeset.dart (right):

https://codereview.chromium.org/1815693002/diff/20001/pkg/compiler/lib/src/or...
pkg/compiler/lib/src/ordered_typeset.dart:166: if (_objectType == null) {
On 2016/03/18 20:23:13, Siggi Cherem (dart-lang) wrote:
> it's a bit strange to always recompute object...
> 
> Would it make sense to have the deserializer create an instance of CoreTypes
and
> CoreClasses as well? Then you could make it a mandatory argument in the ctor.

Adding a TODO.

https://codereview.chromium.org/1815693002/diff/20001/pkg/compiler/lib/src/se...
File pkg/compiler/lib/src/serialization/modelz.dart (right):

https://codereview.chromium.org/1815693002/diff/20001/pkg/compiler/lib/src/se...
pkg/compiler/lib/src/serialization/modelz.dart:938: return _mixinType;
On 2016/03/18 20:23:13, Siggi Cherem (dart-lang) wrote:
> sugar:
> 
>   get mixinType => _mixinType ??= _decoder.getType(Key.MIXIN);

Done.

https://codereview.chromium.org/1815693002/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/serialization_test.dart (right):

https://codereview.chromium.org/1815693002/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/serialization_test.dart:551: // TODO(johnniwinther):
Ensure abstract fields are handled correctly.
On 2016/03/18 20:23:13, Siggi Cherem (dart-lang) wrote:
> move TODO next to the throw?

Moved into the then-branch.

https://codereview.chromium.org/1815693002/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/serialization_test.dart:552: String message =
On 2016/03/18 20:23:13, Siggi Cherem (dart-lang) wrote:
> move message within the if?

It's used in both branches.

https://codereview.chromium.org/1815693002/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/serialization_test.dart:572: //print('Checking member
${member1} against ${member2}');
On 2016/03/18 20:23:13, Siggi Cherem (dart-lang) wrote:
> delete

Done.

Powered by Google App Engine
This is Rietveld 408576698