Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: tests/compiler/dart2js/serialization_test.dart

Issue 1815693002: Don't serialize unnamed mixin applications. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comments. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/serialization/serialization.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/serialization_test.dart
diff --git a/tests/compiler/dart2js/serialization_test.dart b/tests/compiler/dart2js/serialization_test.dart
index 3522c414ce6c8bc6afe9ec3d71c6d0c8b128eb56..933fc8804316c9c030c7252f1b27d93bd769e023 100644
--- a/tests/compiler/dart2js/serialization_test.dart
+++ b/tests/compiler/dart2js/serialization_test.dart
@@ -548,12 +548,26 @@ class ElementPropertyEquivalence extends BaseElementVisitor<dynamic, Element> {
Element member1 = element1.localLookup(name);
Element member2 = element2.localLookup(name);
if (member1 == null) {
- print('Missing member for $member2 in\n ${members1.join('\n ')}');
- continue;
+ String message =
+ 'Missing member for $member2 in\n ${members1.join('\n ')}';
+ if (member2.isAbstractField) {
+ // TODO(johnniwinther): Ensure abstract fields are handled correctly.
+ print(message);
+ continue;
+ } else {
+ throw message;
+ }
}
if (member2 == null) {
- print('Missing member for $member1 in\n ${members2.join('\n ')}');
- continue;
+ String message =
+ 'Missing member for $member1 in\n ${members2.join('\n ')}';
+ if (member1.isAbstractField) {
+ // TODO(johnniwinther): Ensure abstract fields are handled correctly.
+ print(message);
+ continue;
+ } else {
+ throw message;
+ }
}
visit(member1, member2);
}
@@ -621,6 +635,15 @@ class ElementPropertyEquivalence extends BaseElementVisitor<dynamic, Element> {
element1.interfaces.toList(),
element2.interfaces.toList());
+ List<ConstructorElement> getConstructors(ClassElement cls) {
+ return cls.implementation.constructors.map((c) => c.declaration).toList();
+ }
+
+ checkElementLists(
+ element1, element2, 'constructors',
+ getConstructors(element1),
+ getConstructors(element2));
+
visitMembers(element1, element2);
}
« no previous file with comments | « pkg/compiler/lib/src/serialization/serialization.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698