Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1815573002: DevTools: Move GPU activity on timeline out of experiment. (Closed)

Created:
4 years, 9 months ago by alph
Modified:
4 years, 9 months ago
Reviewers:
caseq, paulirish
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Move GPU activity on timeline out of experiment. BUG=298951 Committed: https://crrev.com/6ecc09b737592bc970013b07690f5ce362cf5abe Cr-Commit-Position: refs/heads/master@{#381866}

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressing comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -30 lines) Patch
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/MemoryCountersGraph.js View 1 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js View 1 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js View 1 4 chunks +16 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
alph
4 years, 9 months ago (2016-03-17 23:49:37 UTC) #2
caseq
lgtm https://codereview.chromium.org/1815573002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js (right): https://codereview.chromium.org/1815573002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js#newcode548 third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js:548: if (this._appendSyncEvents(this._model.gpuTasks().map(record => record.traceEvent()), WebInspector.UIString("GPU"), this._headerLevel1, false)) can ...
4 years, 9 months ago (2016-03-17 23:53:50 UTC) #3
alph
ptal
4 years, 9 months ago (2016-03-18 00:30:04 UTC) #4
caseq
4 years, 9 months ago (2016-03-18 00:32:38 UTC) #5
caseq
lgtm
4 years, 9 months ago (2016-03-18 00:32:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815573002/20001
4 years, 9 months ago (2016-03-18 00:33:44 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-18 01:40:15 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 01:42:57 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6ecc09b737592bc970013b07690f5ce362cf5abe
Cr-Commit-Position: refs/heads/master@{#381866}

Powered by Google App Engine
This is Rietveld 408576698