third_party/WebKit/Source/devtools/front_end/timeline/MemoryCountersGraph.js - Issue 1815573002: DevTools: Move GPU activity on timeline out of experiment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/MemoryCountersGraph.js

Issue 1815573002: DevTools: Move GPU activity on timeline out of experiment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comment Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/main/Main.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/MemoryCountersGraph.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/MemoryCountersGraph.js b/third_party/WebKit/Source/devtools/front_end/timeline/MemoryCountersGraph.js

index 6df05005b9813ea1c2df1307915429beda2558f7..70dcbbb8a8fd4f0227b26e8e43d588f706765dd8 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/MemoryCountersGraph.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/MemoryCountersGraph.js

@@ -44,10 +44,8 @@ WebInspector.MemoryCountersGraph = function(delegate, model, filters)

this._countersByName["documents"] = this.createCounter(WebInspector.UIString("Documents"), WebInspector.UIString("Documents: %s"), "hsl(0, 90%, 43%)");

this._countersByName["nodes"] = this.createCounter(WebInspector.UIString("Nodes"), WebInspector.UIString("Nodes: %s"), "hsl(120, 90%, 43%)");

this._countersByName["jsEventListeners"] = this.createCounter(WebInspector.UIString("Listeners"), WebInspector.UIString("Listeners: %s"), "hsl(38, 90%, 43%)");

- if (Runtime.experiments.isEnabled("gpuTimeline")) {

- this._gpuMemoryCounter = this.createCounter(WebInspector.UIString("GPU Memory"), WebInspector.UIString("GPU Memory [KB]: %s"), "hsl(300, 90%, 43%)", Number.bytesToString);

- this._countersByName["gpuMemoryUsedKB"] = this._gpuMemoryCounter;

- }

+ this._gpuMemoryCounter = this.createCounter(WebInspector.UIString("GPU Memory"), WebInspector.UIString("GPU Memory [KB]: %s"), "hsl(300, 90%, 43%)", Number.bytesToString);

+ this._countersByName["gpuMemoryUsedKB"] = this._gpuMemoryCounter;

}

WebInspector.MemoryCountersGraph.prototype = {

@@ -73,7 +71,7 @@ WebInspector.MemoryCountersGraph.prototype = {

}

var gpuMemoryLimitCounterName = "gpuMemoryLimitKB";

- if (this._gpuMemoryCounter && (gpuMemoryLimitCounterName in counters))

+ if (gpuMemoryLimitCounterName in counters)

this._gpuMemoryCounter.setLimit(counters[gpuMemoryLimitCounterName]);

}

this.scheduleRefresh();