Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 9 months ago by sof Modified:
4 years, 9 months ago Reviewers:
haraken, Ken Russell (switch to Gerrit) CC:
chromium-reviews, blink-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove unnecessary WebGLRenderingContextBase unregistration.
The garbage collector takes care of clearing out weak references to
WebGLRenderingContextBase objects that the |forciblyEvictedContexts()|
and |activateContexts()| sets keep, before the objects are finalized.
Hence no need to additionally attempt to remove; just assert
non-membership.
R=haraken
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
Committed: https://crrev.com/fa7d8b396b85d9b6440a4f430ff90eb6a4c4a680
Cr-Commit-Position: refs/heads/master@{#381916}
Patch Set 1 #Patch Set 2 : comment wording #
Created: 4 years, 9 months ago
Messages
Total messages: 13 (6 generated)
Description was changed from ========== Remove unnecessary WebGLRenderingContextBase unregistration. The garbage collector takes care of clearing out weak references to WebGLRenderingContextBase objects that the |forciblyEvictedContexts()| and |activateContexts()| sets keep, before the objects are finalized. Hence no need to additionally attempt to remove; just assert non-membership. R= BUG= ========== to ========== Remove unnecessary WebGLRenderingContextBase unregistration. The garbage collector takes care of clearing out weak references to WebGLRenderingContextBase objects that the |forciblyEvictedContexts()| and |activateContexts()| sets keep, before the objects are finalized. Hence no need to additionally attempt to remove; just assert non-membership. R= BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
sigbjornf@opera.com changed reviewers: + haraken@chromium.org, kbr@chromium.org
please take a look. There's good test coverage for the handling of weak references from collections already, but as there is a mixture of implicit and explicit (un)registration for these context objects, asserts are in order.
LGTM
Description was changed from ========== Remove unnecessary WebGLRenderingContextBase unregistration. The garbage collector takes care of clearing out weak references to WebGLRenderingContextBase objects that the |forciblyEvictedContexts()| and |activateContexts()| sets keep, before the objects are finalized. Hence no need to additionally attempt to remove; just assert non-membership. R= BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== Remove unnecessary WebGLRenderingContextBase unregistration. The garbage collector takes care of clearing out weak references to WebGLRenderingContextBase objects that the |forciblyEvictedContexts()| and |activateContexts()| sets keep, before the objects are finalized. Hence no need to additionally attempt to remove; just assert non-membership. R=haraken BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815513002/20001
Message was sent while issue was closed.
Description was changed from ========== Remove unnecessary WebGLRenderingContextBase unregistration. The garbage collector takes care of clearing out weak references to WebGLRenderingContextBase objects that the |forciblyEvictedContexts()| and |activateContexts()| sets keep, before the objects are finalized. Hence no need to additionally attempt to remove; just assert non-membership. R=haraken BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== Remove unnecessary WebGLRenderingContextBase unregistration. The garbage collector takes care of clearing out weak references to WebGLRenderingContextBase objects that the |forciblyEvictedContexts()| and |activateContexts()| sets keep, before the objects are finalized. Hence no need to additionally attempt to remove; just assert non-membership. R=haraken BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove unnecessary WebGLRenderingContextBase unregistration. The garbage collector takes care of clearing out weak references to WebGLRenderingContextBase objects that the |forciblyEvictedContexts()| and |activateContexts()| sets keep, before the objects are finalized. Hence no need to additionally attempt to remove; just assert non-membership. R=haraken BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== Remove unnecessary WebGLRenderingContextBase unregistration. The garbage collector takes care of clearing out weak references to WebGLRenderingContextBase objects that the |forciblyEvictedContexts()| and |activateContexts()| sets keep, before the objects are finalized. Hence no need to additionally attempt to remove; just assert non-membership. R=haraken BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/fa7d8b396b85d9b6440a4f430ff90eb6a4c4a680 Cr-Commit-Position: refs/heads/master@{#381916} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/fa7d8b396b85d9b6440a4f430ff90eb6a4c4a680 Cr-Commit-Position: refs/heads/master@{#381916}
Message was sent while issue was closed.
Thanks for the fix. Is this related to Issue 594129?
Message was sent while issue was closed.
On 2016/03/19 04:46:15, Ken Russell wrote: > Thanks for the fix. Is this related to Issue 594129? Yes, a detail that showed up while going over the finalization of WebGLRenderingContextBase. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
