Remove unnecessary WebGLRenderingContextBase unregistration.

Remove unnecessary WebGLRenderingContextBase unregistration.

The garbage collector takes care of clearing out weak references to
WebGLRenderingContextBase objects that the |forciblyEvictedContexts()|
and |activateContexts()| sets keep, before the objects are finalized.

Hence no need to additionally attempt to remove; just assert
non-membership.

R=haraken
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/fa7d8b396b85d9b6440a4f430ff90eb6a4c4a680
Cr-Commit-Position: refs/heads/master@{#381916}

[sof, 2016-03-17 22:28:05]

Description was changed from

==========
Remove unnecessary WebGLRenderingContextBase unregistration.

The garbage collector takes care of clearing out weak references to
WebGLRenderingContextBase objects that the |forciblyEvictedContexts()|
and |activateContexts()| sets keep, before the objects are finalized.

Hence no need to additionally attempt to remove; just assert
non-membership.

R=
BUG=
==========

to

==========
Remove unnecessary WebGLRenderingContextBase unregistration.

The garbage collector takes care of clearing out weak references to
WebGLRenderingContextBase objects that the |forciblyEvictedContexts()|
and |activateContexts()| sets keep, before the objects are finalized.

Hence no need to additionally attempt to remove; just assert
non-membership.

R=
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[sof, 2016-03-18 06:35:52]

sigbjornf@opera.com changed reviewers:
+ haraken@chromium.org, kbr@chromium.org

[sof, 2016-03-18 06:35:53]

please take a look.

There's good test coverage for the handling of weak references from collections
already, but as there is a mixture of implicit and explicit (un)registration for
these context objects, asserts are in order.

[haraken, 2016-03-18 06:49:22]

LGTM

[sof, 2016-03-18 08:12:09]

Description was changed from

==========
Remove unnecessary WebGLRenderingContextBase unregistration.

The garbage collector takes care of clearing out weak references to
WebGLRenderingContextBase objects that the |forciblyEvictedContexts()|
and |activateContexts()| sets keep, before the objects are finalized.

Hence no need to additionally attempt to remove; just assert
non-membership.

R=
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Remove unnecessary WebGLRenderingContextBase unregistration.

The garbage collector takes care of clearing out weak references to
WebGLRenderingContextBase objects that the |forciblyEvictedContexts()|
and |activateContexts()| sets keep, before the objects are finalized.

Hence no need to additionally attempt to remove; just assert
non-membership.

R=haraken
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[sof, 2016-03-18 08:12:13]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-03-18 08:12:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1815513002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1815513002/20001

[commit-bot: I haz the power, 2016-03-18 09:11:07]

Description was changed from

==========
Remove unnecessary WebGLRenderingContextBase unregistration.

The garbage collector takes care of clearing out weak references to
WebGLRenderingContextBase objects that the |forciblyEvictedContexts()|
and |activateContexts()| sets keep, before the objects are finalized.

Hence no need to additionally attempt to remove; just assert
non-membership.

R=haraken
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Remove unnecessary WebGLRenderingContextBase unregistration.

The garbage collector takes care of clearing out weak references to
WebGLRenderingContextBase objects that the |forciblyEvictedContexts()|
and |activateContexts()| sets keep, before the objects are finalized.

Hence no need to additionally attempt to remove; just assert
non-membership.

R=haraken
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-03-18 09:11:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-18 09:12:25]

Description was changed from

==========
Remove unnecessary WebGLRenderingContextBase unregistration.

The garbage collector takes care of clearing out weak references to
WebGLRenderingContextBase objects that the |forciblyEvictedContexts()|
and |activateContexts()| sets keep, before the objects are finalized.

Hence no need to additionally attempt to remove; just assert
non-membership.

R=haraken
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Remove unnecessary WebGLRenderingContextBase unregistration.

The garbage collector takes care of clearing out weak references to
WebGLRenderingContextBase objects that the |forciblyEvictedContexts()|
and |activateContexts()| sets keep, before the objects are finalized.

Hence no need to additionally attempt to remove; just assert
non-membership.

R=haraken
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/fa7d8b396b85d9b6440a4f430ff90eb6a4c4a680
Cr-Commit-Position: refs/heads/master@{#381916}
==========

[commit-bot: I haz the power, 2016-03-18 09:12:26]

Patchset 2 (id:??) landed as
https://crrev.com/fa7d8b396b85d9b6440a4f430ff90eb6a4c4a680
Cr-Commit-Position: refs/heads/master@{#381916}

[Ken Russell (switch to Gerrit), 2016-03-19 04:46:15]

Thanks for the fix. Is this related to Issue 594129?

[sof, 2016-03-19 06:48:45]

On 2016/03/19 04:46:15, Ken Russell wrote:
> Thanks for the fix. Is this related to Issue 594129?

Yes, a detail that showed up while going over the finalization of
WebGLRenderingContextBase.