Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Issue 1815513002: Remove unnecessary WebGLRenderingContextBase unregistration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment wording Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
index 5ca7f02851af3d9a8950c6e5695d30daf779ca20..e8677e30f41e0d846753573a44882d51c8ae9a37 100644
--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
@@ -205,8 +205,15 @@ void WebGLRenderingContextBase::removeFromEvictedList(WebGLRenderingContextBase*
void WebGLRenderingContextBase::willDestroyContext(WebGLRenderingContextBase* context)
{
+#if ENABLE(OILPAN)
+ // These two sets keep weak references to their contexts;
+ // verify that the GC already removed the |context| entries.
+ ASSERT(!forciblyEvictedContexts().contains(context));
+ ASSERT(!activeContexts().contains(context));
+#else
removeFromEvictedList(context);
deactivateContext(context);
+#endif
// Try to re-enable the oldest inactive contexts.
while (activeContexts().size() < maxGLActiveContexts && forciblyEvictedContexts().size()) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698