Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1815463002: Remove win8/metro_driver (Closed)

Created:
4 years, 9 months ago by scottmg
Modified:
4 years, 9 months ago
Reviewers:
ananta
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove win8/metro_driver Dead code now. R=ananta@chromium.org BUG=558054 Committed: https://crrev.com/eff89b21d516cc5f9ec85ce455eeaf5f3a1817b7 Cr-Commit-Position: refs/heads/master@{#382101}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7328 lines) Patch
M tools/resources/optimize-png-files.sh View 1 1 chunk +1 line, -1 line 0 comments Download
D win8/metro_driver/BUILD.gn View 1 chunk +0 lines, -102 lines 0 comments Download
D win8/metro_driver/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D win8/metro_driver/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D win8/metro_driver/chrome_app_view.h View 1 chunk +0 lines, -172 lines 0 comments Download
D win8/metro_driver/chrome_app_view.cc View 1 chunk +0 lines, -1216 lines 0 comments Download
D win8/metro_driver/chrome_url_launch_handler.h View 1 chunk +0 lines, -58 lines 0 comments Download
D win8/metro_driver/chrome_url_launch_handler.cc View 1 chunk +0 lines, -207 lines 0 comments Download
D win8/metro_driver/devices_handler.h View 1 chunk +0 lines, -31 lines 0 comments Download
D win8/metro_driver/devices_handler.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D win8/metro_driver/direct3d_helper.h View 1 chunk +0 lines, -45 lines 0 comments Download
D win8/metro_driver/direct3d_helper.cc View 1 chunk +0 lines, -150 lines 0 comments Download
D win8/metro_driver/display_properties.h View 1 chunk +0 lines, -11 lines 0 comments Download
D win8/metro_driver/display_properties.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D win8/metro_driver/ime/BUILD.gn View 1 chunk +0 lines, -29 lines 0 comments Download
D win8/metro_driver/ime/ime.gypi View 1 chunk +0 lines, -23 lines 0 comments Download
D win8/metro_driver/ime/ime_popup_monitor.h View 1 chunk +0 lines, -19 lines 0 comments Download
D win8/metro_driver/ime/ime_popup_monitor.cc View 1 chunk +0 lines, -82 lines 0 comments Download
D win8/metro_driver/ime/ime_popup_observer.h View 1 chunk +0 lines, -27 lines 0 comments Download
D win8/metro_driver/ime/input_scope.h View 1 chunk +0 lines, -22 lines 0 comments Download
D win8/metro_driver/ime/input_scope.cc View 1 chunk +0 lines, -88 lines 0 comments Download
D win8/metro_driver/ime/input_source.h View 1 chunk +0 lines, -36 lines 0 comments Download
D win8/metro_driver/ime/input_source.cc View 1 chunk +0 lines, -172 lines 0 comments Download
D win8/metro_driver/ime/input_source_observer.h View 1 chunk +0 lines, -25 lines 0 comments Download
D win8/metro_driver/ime/text_service.h View 1 chunk +0 lines, -53 lines 0 comments Download
D win8/metro_driver/ime/text_service.cc View 1 chunk +0 lines, -490 lines 0 comments Download
D win8/metro_driver/ime/text_service_delegate.h View 1 chunk +0 lines, -41 lines 0 comments Download
D win8/metro_driver/ime/text_store.h View 1 chunk +0 lines, -316 lines 0 comments Download
D win8/metro_driver/ime/text_store.cc View 1 chunk +0 lines, -897 lines 0 comments Download
D win8/metro_driver/ime/text_store_delegate.h View 1 chunk +0 lines, -55 lines 0 comments Download
D win8/metro_driver/metro_dialog_box.h View 1 chunk +0 lines, -64 lines 0 comments Download
D win8/metro_driver/metro_dialog_box.cc View 1 chunk +0 lines, -160 lines 0 comments Download
D win8/metro_driver/metro_driver.gyp View 1 chunk +0 lines, -126 lines 0 comments Download
D win8/metro_driver/metro_driver_dll.ver View 1 chunk +0 lines, -2 lines 0 comments Download
D win8/metro_driver/print_document_source.h View 1 chunk +0 lines, -165 lines 0 comments Download
D win8/metro_driver/print_document_source.cc View 1 chunk +0 lines, -529 lines 0 comments Download
D win8/metro_driver/print_handler.h View 1 chunk +0 lines, -117 lines 0 comments Download
D win8/metro_driver/print_handler.cc View 1 chunk +0 lines, -491 lines 0 comments Download
D win8/metro_driver/run_all_unittests.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D win8/metro_driver/secondary_tile.h View 1 chunk +0 lines, -27 lines 0 comments Download
D win8/metro_driver/secondary_tile.cc View 1 chunk +0 lines, -229 lines 0 comments Download
D win8/metro_driver/settings_handler.h View 1 chunk +0 lines, -44 lines 0 comments Download
D win8/metro_driver/settings_handler.cc View 1 chunk +0 lines, -175 lines 0 comments Download
D win8/metro_driver/stdafx.h View 1 chunk +0 lines, -40 lines 0 comments Download
D win8/metro_driver/toast_notification_handler.h View 1 chunk +0 lines, -55 lines 0 comments Download
D win8/metro_driver/toast_notification_handler.cc View 1 chunk +0 lines, -253 lines 0 comments Download
D win8/metro_driver/winrt_utils.h View 1 chunk +0 lines, -60 lines 0 comments Download
D win8/metro_driver/winrt_utils.cc View 1 chunk +0 lines, -226 lines 0 comments Download
D win8/metro_driver/winrt_utils_unittest.cc View 1 chunk +0 lines, -115 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
scottmg
4 years, 9 months ago (2016-03-17 19:53:56 UTC) #3
ananta
lgtm
4 years, 9 months ago (2016-03-18 19:58:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815463002/20001
4 years, 9 months ago (2016-03-18 20:16:34 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-18 21:54:39 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 21:56:21 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/eff89b21d516cc5f9ec85ce455eeaf5f3a1817b7
Cr-Commit-Position: refs/heads/master@{#382101}

Powered by Google App Engine
This is Rietveld 408576698