Force test plugin to be windowless only

Force test plugin to be windowless only.

AFAICT we don't depend on windowed functionality for LayoutTests. This would allow us to remove a large bunch of code on the chrome side.

BUG=493212
Committed: https://crrev.com/7254ad0b42e85cfd6025568a15f24af12570b429
Cr-Commit-Position: refs/heads/master@{#381982}

[piman, 2016-03-17 23:35:54]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-17 23:36:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1815453003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1815453003/1

[commit-bot: I haz the power, 2016-03-17 23:44:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 23:44:04]

Dry run: This issue passed the CQ dry run.

[piman, 2016-03-18 00:20:49]

Description was changed from

==========
Force test plugin to be windowless only

BUG=None
==========

to

==========
Force test plugin to be windowless only.

AFAICT we don't depend on windowed functionality for LayoutTests. This would
allow us to remove a large bunch of code on the chrome side.

BUG=493212
==========

[piman, 2016-03-18 00:21:03]

piman@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2016-03-18 06:10:53]

lgtm

https://codereview.chromium.org/1815453003/diff/1/content/shell/tools/plugin/...
File content/shell/tools/plugin/main.cpp (right):

https://codereview.chromium.org/1815453003/diff/1/content/shell/tools/plugin/...
content/shell/tools/plugin/main.cpp:272: browser->setvalue(instance,
NPPVpluginWindowBool, windowed);
o.O

[piman, 2016-03-18 15:55:40]

https://codereview.chromium.org/1815453003/diff/1/content/shell/tools/plugin/...
File content/shell/tools/plugin/main.cpp (right):

https://codereview.chromium.org/1815453003/diff/1/content/shell/tools/plugin/...
content/shell/tools/plugin/main.cpp:272: browser->setvalue(instance,
NPPVpluginWindowBool, windowed);
On 2016/03/18 06:10:53, dcheng wrote:
> o.O

NPAPI is insane. Not my fault :)

[piman, 2016-03-18 15:55:45]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-03-18 15:56:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1815453003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1815453003/1

[commit-bot: I haz the power, 2016-03-18 16:00:42]

Description was changed from

==========
Force test plugin to be windowless only.

AFAICT we don't depend on windowed functionality for LayoutTests. This would
allow us to remove a large bunch of code on the chrome side.

BUG=493212
==========

to

==========
Force test plugin to be windowless only.

AFAICT we don't depend on windowed functionality for LayoutTests. This would
allow us to remove a large bunch of code on the chrome side.

BUG=493212
==========

[commit-bot: I haz the power, 2016-03-18 16:00:43]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-18 16:02:02]

Description was changed from

==========
Force test plugin to be windowless only.

AFAICT we don't depend on windowed functionality for LayoutTests. This would
allow us to remove a large bunch of code on the chrome side.

BUG=493212
==========

to

==========
Force test plugin to be windowless only.

AFAICT we don't depend on windowed functionality for LayoutTests. This would
allow us to remove a large bunch of code on the chrome side.

BUG=493212

Committed: https://crrev.com/7254ad0b42e85cfd6025568a15f24af12570b429
Cr-Commit-Position: refs/heads/master@{#381982}
==========

[commit-bot: I haz the power, 2016-03-18 16:02:03]

Patchset 1 (id:??) landed as
https://crrev.com/7254ad0b42e85cfd6025568a15f24af12570b429
Cr-Commit-Position: refs/heads/master@{#381982}