Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2371)

Unified Diff: content/shell/tools/plugin/main.cpp

Issue 1815453003: Force test plugin to be windowless only (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/tools/plugin/PluginObject.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/tools/plugin/main.cpp
diff --git a/content/shell/tools/plugin/main.cpp b/content/shell/tools/plugin/main.cpp
index bd3f4cdcd8626685bfdc721ac481dc17905e9e0e..2a6cba7e9deacd208017d1712d81706648cdd8fd 100644
--- a/content/shell/tools/plugin/main.cpp
+++ b/content/shell/tools/plugin/main.cpp
@@ -264,19 +264,12 @@ NPError NPP_New(NPMIMEType pluginType, NPP instance, uint16_t mode, int16_t argc
// When testing evaluate script on mouse-down or key-down, allow event logging to handle events.
if (obj->evaluateScriptOnMouseDownOrKeyDown)
obj->eventLogging = true;
- } else if (!strcasecmp(argn[i], "windowedPlugin")) {
- void* windowed = 0;
- if (!strcasecmp(argv[i], "false") || !strcasecmp(argv[i], "0"))
- windowed = 0;
- else if (!strcasecmp(argv[i], "true") || !strcasecmp(argv[i], "1"))
- windowed = reinterpret_cast<void*>(1);
- else
- assert(false);
- browser->setvalue(instance, NPPVpluginWindowBool, windowed);
} else if (!strcasecmp(argn[i], "alwaysFilterEvents")) {
obj->alwaysFilterEvents = true;
}
}
+ void* windowed = 0;
+ browser->setvalue(instance, NPPVpluginWindowBool, windowed);
dcheng 2016/03/18 06:10:53 o.O
piman 2016/03/18 15:55:40 NPAPI is insane. Not my fault :)
#ifdef XP_MACOSX
browser->setvalue(instance, NPPVpluginDrawingModel, (void *)NPDrawingModelCoreGraphics);
« no previous file with comments | « content/shell/tools/plugin/PluginObject.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698