chrome/browser/extensions/api/management/chrome_management_api_delegate.cc - Issue 1815363002: Add RetainedRef uses where needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

Issue 1815363002: Add RetainedRef uses where needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/extension_action/browser_action_browsertest.cc ('k') | chrome/browser/extensions/app_data_migrator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

diff --git a/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc b/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

index 545a55d5366775934965a7deb5fa3213862e86f5..caeedfeb39009c0199c57841b1bc1029912a62ef 100644

--- a/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

+++ b/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

@@ -275,12 +275,9 @@ ChromeManagementAPIDelegate::GenerateAppForLinkFunctionDelegate(

favicon_service->GetFaviconImageForPageURL(

launch_url,

- base::Bind(

- &ChromeAppForLinkDelegate::OnFaviconForApp,

- base::Unretained(delegate),

- scoped_refptr<extensions::ManagementGenerateAppForLinkFunction>(

- function),

- context, title, launch_url),

+ base::Bind(&ChromeAppForLinkDelegate::OnFaviconForApp,

+ base::Unretained(delegate), base::RetainedRef(function),

+ context, title, launch_url),

&delegate->cancelable_task_tracker_);

return scoped_ptr<extensions::AppForLinkDelegate>(delegate);