chrome/browser/extensions/api/extension_action/browser_action_browsertest.cc - Issue 1815363002: Add RetainedRef uses where needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/browser_action_browsertest.cc

Issue 1815363002: Add RetainedRef uses where needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/errorpage_browsertest.cc ('k') | chrome/browser/extensions/api/management/chrome_management_api_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/browser_action_browsertest.cc

diff --git a/chrome/browser/extensions/api/extension_action/browser_action_browsertest.cc b/chrome/browser/extensions/api/extension_action/browser_action_browsertest.cc

index 099f869f7e0cf0fcd375a3e168b784315cc09c67..555e7faf9d86f696e40c8a37c450cddc53ee4a03 100644

--- a/chrome/browser/extensions/api/extension_action/browser_action_browsertest.cc

+++ b/chrome/browser/extensions/api/extension_action/browser_action_browsertest.cc

@@ -37,9 +37,8 @@ void WaitForStateStore(Profile* profile, const std::string& extension_id) {

scoped_refptr<content::MessageLoopRunner> runner =

new content::MessageLoopRunner;

ExtensionSystem::Get(profile)->state_store()->GetExtensionValue(

- extension_id,

- kBrowserActionStorageKey,

- base::Bind(&QuitMessageLoop, runner));

+ extension_id, kBrowserActionStorageKey,

+ base::Bind(&QuitMessageLoop, base::RetainedRef(runner)));

runner->Run();

}