content/browser/tracing/tracing_controller_impl_data_sinks.cc - Issue 1815363002: Add RetainedRef uses where needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tracing/tracing_controller_impl_data_sinks.cc

Issue 1815363002: Add RetainedRef uses where needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/tracing/tracing_controller_impl_data_sinks.cc

diff --git a/content/browser/tracing/tracing_controller_impl_data_sinks.cc b/content/browser/tracing/tracing_controller_impl_data_sinks.cc

index 025619f2024222de0fbf833374a8e7aa273761e7..1ee6327893aad4cbbf028b0de0034db24642d901 100644

--- a/content/browser/tracing/tracing_controller_impl_data_sinks.cc

+++ b/content/browser/tracing/tracing_controller_impl_data_sinks.cc

@@ -34,9 +34,10 @@ class StringTraceDataEndpoint : public TracingController::TraceDataEndpoint {

scoped_refptr<base::RefCountedString> str =

base::RefCountedString::TakeString(&tmp);

- BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,

- base::Bind(completion_callback_,

- base::Passed(std::move(metadata)), str));

+ BrowserThread::PostTask(

+ BrowserThread::UI, FROM_HERE,

+ base::Bind(completion_callback_, base::Passed(std::move(metadata)),

+ base::RetainedRef(str)));

}

private: