Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1815333002: Simpler regex names: (Closed)

Created:
4 years, 9 months ago by rmacnak
Modified:
4 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Simpler regex names: C++ JSRegExp -> RegExp Dart _JSSyntaxRegExp -> _RegExp Function RegExp.:irregexp: pattern -> RegExp.:matcher: pattern R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/b070d98f6ead4e420a71593f6a578e8a9d84f77d

Patch Set 1 #

Patch Set 2 : update fingerprint, fix alignment #

Patch Set 3 : #

Patch Set 4 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -152 lines) Patch
M runtime/lib/regexp.cc View 1 3 chunks +17 lines, -17 lines 0 comments Download
M runtime/lib/regexp_patch.dart View 10 chunks +31 lines, -31 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 1 chunk +6 lines, -6 lines 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/method_recognizer.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 1 2 3 6 chunks +12 lines, -12 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 10 chunks +26 lines, -26 lines 0 comments Download
M runtime/vm/object_service.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/raw_object.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/raw_object.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 2 3 2 chunks +12 lines, -12 lines 0 comments Download
M runtime/vm/regexp.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/regexp.cc View 1 2 3 5 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/regexp_assembler_bytecode.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/regexp_assembler_bytecode.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/regexp_assembler_ir.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/regexp_assembler_ir.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/regexp_parser.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/regexp_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/snapshot.h View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/symbols.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 9 months ago (2016-03-18 20:22:01 UTC) #2
Cutch
lgtm
4 years, 9 months ago (2016-03-21 20:27:19 UTC) #3
rmacnak
4 years, 9 months ago (2016-03-22 00:21:10 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
b070d98f6ead4e420a71593f6a578e8a9d84f77d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698