Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: runtime/vm/object.h

Issue 1815333002: Simpler regex names: (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: sync Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/method_recognizer.h ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
diff --git a/runtime/vm/object.h b/runtime/vm/object.h
index 9a8d743be1420fc0b17b946727c8fc131bb14d34..1ed09f76d514b35db04d259d4fe7c98947aa46e3 100644
--- a/runtime/vm/object.h
+++ b/runtime/vm/object.h
@@ -2198,9 +2198,9 @@ class Function : public Object {
RawScript* script() const;
RawObject* RawOwner() const { return raw_ptr()->owner_; }
- RawJSRegExp* regexp() const;
+ RawRegExp* regexp() const;
intptr_t string_specialization_cid() const;
- void SetRegExpData(const JSRegExp& regexp,
+ void SetRegExpData(const RegExp& regexp,
intptr_t string_specialization_cid) const;
RawString* native_name() const;
@@ -5234,7 +5234,7 @@ class Instance : public Object {
friend class Class;
friend class Closure;
friend class DeferredObject;
- friend class JSRegExp;
+ friend class RegExp;
friend class SnapshotWriter;
friend class StubCode;
friend class TypedDataView;
@@ -8038,7 +8038,7 @@ class Stacktrace : public Instance {
// Internal JavaScript regular expression object.
-class JSRegExp : public Instance {
+class RegExp : public Instance {
public:
// Meaning of RegExType:
// kUninitialized: the type of th regexp has not been initialized yet.
@@ -8092,13 +8092,13 @@ class JSRegExp : public Instance {
static intptr_t function_offset(intptr_t cid) {
switch (cid) {
case kOneByteStringCid:
- return OFFSET_OF(RawJSRegExp, one_byte_function_);
+ return OFFSET_OF(RawRegExp, one_byte_function_);
case kTwoByteStringCid:
- return OFFSET_OF(RawJSRegExp, two_byte_function_);
+ return OFFSET_OF(RawRegExp, two_byte_function_);
case kExternalOneByteStringCid:
- return OFFSET_OF(RawJSRegExp, external_one_byte_function_);
+ return OFFSET_OF(RawRegExp, external_one_byte_function_);
case kExternalTwoByteStringCid:
- return OFFSET_OF(RawJSRegExp, external_two_byte_function_);
+ return OFFSET_OF(RawRegExp, external_two_byte_function_);
}
UNREACHABLE();
@@ -8129,16 +8129,16 @@ class JSRegExp : public Instance {
}
void* GetDataStartAddress() const;
- static RawJSRegExp* FromDataStartAddress(void* data);
+ static RawRegExp* FromDataStartAddress(void* data);
const char* Flags() const;
virtual bool CanonicalizeEquals(const Instance& other) const;
static intptr_t InstanceSize() {
- return RoundedAllocationSize(sizeof(RawJSRegExp));
+ return RoundedAllocationSize(sizeof(RawRegExp));
}
- static RawJSRegExp* New(Heap::Space space = Heap::kNew);
+ static RawRegExp* New(Heap::Space space = Heap::kNew);
private:
void set_type(RegExType type) const {
@@ -8157,7 +8157,7 @@ class JSRegExp : public Instance {
return FlagsBits::decode(raw_ptr()->type_flags_);
}
- FINAL_HEAP_OBJECT_IMPLEMENTATION(JSRegExp, Instance);
+ FINAL_HEAP_OBJECT_IMPLEMENTATION(RegExp, Instance);
friend class Class;
};
« no previous file with comments | « runtime/vm/method_recognizer.h ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698