Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: tools/perf/benchmarks/page_cycler.py

Issue 1815243002: Disable page_cycler.basic_oopif on zenbook bot (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Check using BUILDBOT_BUILDERNAME variable Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/page_cycler.py
diff --git a/tools/perf/benchmarks/page_cycler.py b/tools/perf/benchmarks/page_cycler.py
index c6d3764bf0edfa5b90f39fdddb9f717064cbf430..87c5a6e6ac0c8b51f4b9008864e150cc05859194 100644
--- a/tools/perf/benchmarks/page_cycler.py
+++ b/tools/perf/benchmarks/page_cycler.py
@@ -1,6 +1,7 @@
# Copyright 2013 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import os
petrcermak 2016/03/18 15:49:13 nit: I think that there should be an empty line ab
nednguyen 2016/03/18 15:52:23 Done.
from core import perf_benchmark
@@ -250,6 +251,11 @@ class PageCyclerBasicOopifIsolated(_PageCycler):
def SetExtraBrowserOptions(self, options):
options.AppendExtraBrowserArgs(['--site-per-process'])
+ @classmethod
+ def ShouldDisable(cls, possible_browser): # http://crbug.com/596067
+ # This test is flaky on zenbook laptops of chromium perf lab.
petrcermak 2016/03/18 15:49:13 nit: s/zenbook/Zenbook/, s/of chromium/in the Chro
nednguyen 2016/03/18 15:52:23 Done.
+ return 'Zenbook' in os.getenv('BUILDBOT_BUILDERNAME', '')
+
@benchmark.Disabled('reference') # crbug.com/523346
class PageCyclerBasicOopif(_PageCycler):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698