Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Side by Side Diff: tools/perf/benchmarks/page_cycler.py

Issue 1815243002: Disable page_cycler.basic_oopif on zenbook bot (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Check using BUILDBOT_BUILDERNAME variable Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import os
petrcermak 2016/03/18 15:49:13 nit: I think that there should be an empty line ab
nednguyen 2016/03/18 15:52:23 Done.
4 5
5 from core import perf_benchmark 6 from core import perf_benchmark
6 7
7 from measurements import page_cycler 8 from measurements import page_cycler
8 import page_sets 9 import page_sets
9 from telemetry import benchmark 10 from telemetry import benchmark
10 11
11 12
12 class _PageCycler(perf_benchmark.PerfBenchmark): 13 class _PageCycler(perf_benchmark.PerfBenchmark):
13 options = {'pageset_repeat': 6} 14 options = {'pageset_repeat': 6}
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 """ A benchmark measuring performance of out-of-process iframes. """ 244 """ A benchmark measuring performance of out-of-process iframes. """
244 page_set = page_sets.OopifBasicPageSet 245 page_set = page_sets.OopifBasicPageSet
245 246
246 @classmethod 247 @classmethod
247 def Name(cls): 248 def Name(cls):
248 return 'page_cycler_site_isolation.basic_oopif' 249 return 'page_cycler_site_isolation.basic_oopif'
249 250
250 def SetExtraBrowserOptions(self, options): 251 def SetExtraBrowserOptions(self, options):
251 options.AppendExtraBrowserArgs(['--site-per-process']) 252 options.AppendExtraBrowserArgs(['--site-per-process'])
252 253
254 @classmethod
255 def ShouldDisable(cls, possible_browser): # http://crbug.com/596067
256 # This test is flaky on zenbook laptops of chromium perf lab.
petrcermak 2016/03/18 15:49:13 nit: s/zenbook/Zenbook/, s/of chromium/in the Chro
nednguyen 2016/03/18 15:52:23 Done.
257 return 'Zenbook' in os.getenv('BUILDBOT_BUILDERNAME', '')
258
253 259
254 @benchmark.Disabled('reference') # crbug.com/523346 260 @benchmark.Disabled('reference') # crbug.com/523346
255 class PageCyclerBasicOopif(_PageCycler): 261 class PageCyclerBasicOopif(_PageCycler):
256 """ A benchmark measuring performance of the out-of-process iframes page 262 """ A benchmark measuring performance of the out-of-process iframes page
257 set, without running in out-of-process iframes mode.. """ 263 set, without running in out-of-process iframes mode.. """
258 page_set = page_sets.OopifBasicPageSet 264 page_set = page_sets.OopifBasicPageSet
259 265
260 @classmethod 266 @classmethod
261 def Name(cls): 267 def Name(cls):
262 return 'page_cycler.basic_oopif' 268 return 'page_cycler.basic_oopif'
263 269
264 270
265 @benchmark.Disabled('all') # crbug.com/443730 271 @benchmark.Disabled('all') # crbug.com/443730
266 class PageCyclerBigJs(_PageCycler): 272 class PageCyclerBigJs(_PageCycler):
267 page_set = page_sets.BigJsPageSet 273 page_set = page_sets.BigJsPageSet
268 274
269 @classmethod 275 @classmethod
270 def Name(cls): 276 def Name(cls):
271 return 'page_cycler.big_js' 277 return 'page_cycler.big_js'
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698