Disable page_cycler.basic_oopif on zenbook bot

Disable page_cycler.basic_oopif on zenbook bot

BUG=596067, 595744
Committed: https://crrev.com/15047b716f232fc75525e4afdd81eb892da75640
Cr-Commit-Position: refs/heads/master@{#382065}

[nednguyen, 2016-03-18 15:31:49]

Description was changed from

==========
Disable page_cycler.basic_oopif on low-end win bot

BUG=596067, 595744
==========

to

==========
Disable page_cycler.basic_oopif on low-end win bot

BUG=596067, 595744
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
==========

[nednguyen, 2016-03-18 15:32:17]

nednguyen@google.com changed reviewers:
+ eakuefner@chromium.org, petrcermak@chromium.org

[nednguyen, 2016-03-18 15:33:27]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 15:33:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1815243002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1815243002/1

[petrcermak, 2016-03-18 15:39:52]

This will NOT work. The Zenbook has 4 CPUs
(https://build.chromium.org/p/chromium.perf/builders/Win%20Zenbook%20Perf%20%2...)
and it's not the only perf bot that has this number of CPUs.

Petr

[nednguyen, 2016-03-18 15:40:55]

The CQ bit was unchecked by nednguyen@google.com

[nednguyen, 2016-03-18 15:47:00]

On 2016/03/18 15:39:52, petrcermak wrote:
> This will NOT work. The Zenbook has 4 CPUs
>
(https://build.chromium.org/p/chromium.perf/builders/Win%20Zenbook%20Perf%20%2...)
> and it's not the only perf bot that has this number of CPUs.
> 
> Petr

Updated, PTAL

[nednguyen, 2016-03-18 15:47:19]

Description was changed from

==========
Disable page_cycler.basic_oopif on low-end win bot

BUG=596067, 595744
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
==========

to

==========
Disable page_cycler.basic_oopif on zenbook bot

BUG=596067, 595744
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
==========

[nednguyen, 2016-03-18 15:47:36]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 15:47:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1815243002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1815243002/20001

[petrcermak, 2016-03-18 15:49:13]

LGTM with 2 nits.

Thanks,
Petr

https://codereview.chromium.org/1815243002/diff/20001/tools/perf/benchmarks/p...
File tools/perf/benchmarks/page_cycler.py (right):

https://codereview.chromium.org/1815243002/diff/20001/tools/perf/benchmarks/p...
tools/perf/benchmarks/page_cycler.py:4: import os
nit: I think that there should be an empty line above this one.

https://codereview.chromium.org/1815243002/diff/20001/tools/perf/benchmarks/p...
tools/perf/benchmarks/page_cycler.py:256: # This test is flaky on zenbook
laptops of chromium perf lab.
nit: s/zenbook/Zenbook/, s/of chromium/in the Chromium/

[nednguyen, 2016-03-18 15:52:19]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2016-03-18 15:52:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
petrcermak@chromium.org
Link to the patchset: https://codereview.chromium.org/1815243002/#ps40001
(title: "Address Petr's nits")

[nednguyen, 2016-03-18 15:52:23]

https://codereview.chromium.org/1815243002/diff/20001/tools/perf/benchmarks/p...
File tools/perf/benchmarks/page_cycler.py (right):

https://codereview.chromium.org/1815243002/diff/20001/tools/perf/benchmarks/p...
tools/perf/benchmarks/page_cycler.py:4: import os
On 2016/03/18 15:49:13, petrcermak wrote:
> nit: I think that there should be an empty line above this one.

Done.

https://codereview.chromium.org/1815243002/diff/20001/tools/perf/benchmarks/p...
tools/perf/benchmarks/page_cycler.py:256: # This test is flaky on zenbook
laptops of chromium perf lab.
On 2016/03/18 15:49:13, petrcermak wrote:
> nit: s/zenbook/Zenbook/, s/of chromium/in the Chromium/

Done.

[commit-bot: I haz the power, 2016-03-18 15:52:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1815243002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1815243002/40001

[commit-bot: I haz the power, 2016-03-18 17:54:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 17:54:11]

Try jobs failed on following builders:
  android_s5_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
  linux_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
  mac_retina_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
  winx64_10_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)

[petrcermak, 2016-03-18 18:04:27]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-03-18 18:05:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1815243002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1815243002/40001

[commit-bot: I haz the power, 2016-03-18 20:06:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 20:06:27]

Try jobs failed on following builders:
  android_s5_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
  linux_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
  mac_retina_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
  winx64_10_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)

[nednguyen, 2016-03-18 20:09:20]

Description was changed from

==========
Disable page_cycler.basic_oopif on zenbook bot

BUG=596067, 595744
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
==========

to

==========
Disable page_cycler.basic_oopif on zenbook bot

BUG=596067, 595744
==========

[nednguyen, 2016-03-18 20:09:43]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2016-03-18 20:10:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1815243002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1815243002/40001

[commit-bot: I haz the power, 2016-03-18 20:19:27]

Description was changed from

==========
Disable page_cycler.basic_oopif on zenbook bot

BUG=596067, 595744
==========

to

==========
Disable page_cycler.basic_oopif on zenbook bot

BUG=596067, 595744
==========

[commit-bot: I haz the power, 2016-03-18 20:19:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-18 20:21:26]

Description was changed from

==========
Disable page_cycler.basic_oopif on zenbook bot

BUG=596067, 595744
==========

to

==========
Disable page_cycler.basic_oopif on zenbook bot

BUG=596067, 595744

Committed: https://crrev.com/15047b716f232fc75525e4afdd81eb892da75640
Cr-Commit-Position: refs/heads/master@{#382065}
==========

[commit-bot: I haz the power, 2016-03-18 20:21:27]

Patchset 3 (id:??) landed as
https://crrev.com/15047b716f232fc75525e4afdd81eb892da75640
Cr-Commit-Position: refs/heads/master@{#382065}

[nednguyen, 2016-03-20 15:22:51]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1819743002/ by nednguyen@google.com.

The reason for reverting is: Did not disable the benchmark:
https://uberchromegw.corp.google.com/i/chromium.perf/builders/Win%20Zenbook%2....