src/global-handles.cc - Issue 1815153002: Introduce EmbedderHeapTracer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/global-handles.cc

Issue 1815153002: Introduce EmbedderHeapTracer (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Incorporate Jochen's wonderful comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/global-handles.cc

diff --git a/src/global-handles.cc b/src/global-handles.cc

index 823665cb46c23fe1ffcdf3649c4fb65baaedb6e3..44cc53f642e1f6a48396e5c8bd8df7ef9beb5be7 100644

--- a/src/global-handles.cc

+++ b/src/global-handles.cc

@@ -644,6 +644,9 @@ bool GlobalHandles::IsWeak(Object** location) {

return Node::FromLocation(location)->IsWeak();

}

+void GlobalHandles::AddObjectToMarkingDeque(Object** object, Isolate* isolate) {

+ isolate->heap()->AddObjectToMarkingDeque(object);

void GlobalHandles::IterateWeakRoots(ObjectVisitor* v) {

for (NodeIterator it(this); !it.done(); it.Advance()) {