Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: src/api.cc

Issue 1815153002: Introduce EmbedderHeapTracer (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Incorporate Jochen's wonderful comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index dea23a44f3df6e8e23496002d3bf913b48bd6c03..fc972b0f08dfd2f3e380f472c4b88ff8a5de4797 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -677,6 +677,9 @@ i::Object** V8::CopyPersistent(i::Object** obj) {
return result.location();
}
+void V8::AddObjectToMarkingDeque(i::Object** object, i::Isolate* isolate) {
+ i::GlobalHandles::AddObjectToMarkingDeque(object, isolate);
Hannes Payer (out of office) 2016/03/31 11:13:22 Why do you go through GlobalHandles? You could cal
Marcel Hlopko 2016/03/31 11:58:59 Seemed like I should leave a breadcrumb in the glo
+}
void V8::MakeWeak(i::Object** object, void* parameter,
WeakCallback weak_callback) {
@@ -7174,6 +7177,10 @@ void V8::AddGCEpilogueCallback(GCCallback callback, GCType gc_type) {
reinterpret_cast<v8::Isolate::GCCallback>(callback), gc_type, false);
}
+void Isolate::SetEmbedderHeapTracer(EmbedderHeapTracer* tracer) {
+ i::Isolate* isolate = reinterpret_cast<i::Isolate*>(this);
+ isolate->heap()->SetEmbedderHeapTracer(tracer);
+}
void Isolate::AddMemoryAllocationCallback(MemoryAllocationCallback callback,
ObjectSpace space,

Powered by Google App Engine
This is Rietveld 408576698