third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h - Issue 1815093002: Canvas2d: fix event.region being null on mouseleave/out events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h

Issue 1815093002: Canvas2d: fix event.region being null on mouseleave/out events (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp ('k') | third_party/WebKit/Source/core/input/PointerEventManager.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h

diff --git a/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h b/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h

index 1a07d60bf2f9541e325c16518637e58e3af9379c..2f43ce5fd1ace4e5d8b6e2c57bce13de5d442376 100644

--- a/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h

+++ b/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h

@@ -109,6 +109,7 @@ public:

virtual void setFont(const String&) { }

virtual void styleDidChange(const ComputedStyle* oldStyle, const ComputedStyle& newStyle) { }

virtual std::pair<Element*, String> getControlAndIdIfHitRegionExists(const LayoutPoint& location) { ASSERT_NOT_REACHED(); return std::make_pair(nullptr, String()); }

+ virtual String getIdFromControl(const Element* element) { ASSERT_NOT_REACHED(); return String(); }

Justin Novosad 2016/04/06 18:18:26 I think the code would be cleaner if you removed t

zino 2016/04/07 02:08:16 Done. But I'm a little bit confused. The followin

// WebGL-specific interface

virtual bool is3d() const { return false; }