Chromium Code Reviews Chromium Code Reviews
Issue 1815093002:
Canvas2d: fix event.region being null on mouseleave/out events (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 2009 Apple Inc. All rights reserved. | 2 * Copyright (C) 2009 Apple Inc. All rights reserved. |
| 3 * | 3 * |
| 4 * Redistribution and use in source and binary forms, with or without | 4 * Redistribution and use in source and binary forms, with or without |
| 5 * modification, are permitted provided that the following conditions | 5 * modification, are permitted provided that the following conditions |
| 6 * are met: | 6 * are met: |
| 7 * 1. Redistributions of source code must retain the above copyright | 7 * 1. Redistributions of source code must retain the above copyright |
| 8 * notice, this list of conditions and the following disclaimer. | 8 * notice, this list of conditions and the following disclaimer. |
| 9 * 2. Redistributions in binary form must reproduce the above copyright | 9 * 2. Redistributions in binary form must reproduce the above copyright |
| 10 * notice, this list of conditions and the following disclaimer in the | 10 * notice, this list of conditions and the following disclaimer in the |
| (...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 102 virtual bool is2d() const { return false; } | 102 virtual bool is2d() const { return false; } |
| 103 virtual void restoreCanvasMatrixClipStack(SkCanvas*) const { } | 103 virtual void restoreCanvasMatrixClipStack(SkCanvas*) const { } |
| 104 virtual void reset() { } | 104 virtual void reset() { } |
| 105 virtual void clearRect(double x, double y, double width, double height) { } | 105 virtual void clearRect(double x, double y, double width, double height) { } |
| 106 virtual void didSetSurfaceSize() { } | 106 virtual void didSetSurfaceSize() { } |
| 107 virtual void setShouldAntialias(bool) { } | 107 virtual void setShouldAntialias(bool) { } |
| 108 virtual unsigned hitRegionsCount() const { return 0; } | 108 virtual unsigned hitRegionsCount() const { return 0; } |
| 109 virtual void setFont(const String&) { } | 109 virtual void setFont(const String&) { } |
| 110 virtual void styleDidChange(const ComputedStyle* oldStyle, const ComputedSty le& newStyle) { } | 110 virtual void styleDidChange(const ComputedStyle* oldStyle, const ComputedSty le& newStyle) { } |
| 111 virtual std::pair<Element*, String> getControlAndIdIfHitRegionExists(const L ayoutPoint& location) { ASSERT_NOT_REACHED(); return std::make_pair(nullptr, Str ing()); } | 111 virtual std::pair<Element*, String> getControlAndIdIfHitRegionExists(const L ayoutPoint& location) { ASSERT_NOT_REACHED(); return std::make_pair(nullptr, Str ing()); } |
| 112 virtual String getIdFromControl(const Element* element) { ASSERT_NOT_REACHED (); return String(); } | |
|
Justin Novosad
2016/04/06 18:18:26
I think the code would be cleaner if you removed t
zino
2016/04/07 02:08:16
Done.
But I'm a little bit confused.
The followin
| |
| 112 | 113 |
| 113 // WebGL-specific interface | 114 // WebGL-specific interface |
| 114 virtual bool is3d() const { return false; } | 115 virtual bool is3d() const { return false; } |
| 115 virtual void setFilterQuality(SkFilterQuality) { ASSERT_NOT_REACHED(); } | 116 virtual void setFilterQuality(SkFilterQuality) { ASSERT_NOT_REACHED(); } |
| 116 virtual void reshape(int width, int height) { ASSERT_NOT_REACHED(); } | 117 virtual void reshape(int width, int height) { ASSERT_NOT_REACHED(); } |
| 117 virtual void markLayerComposited() { ASSERT_NOT_REACHED(); } | 118 virtual void markLayerComposited() { ASSERT_NOT_REACHED(); } |
| 118 virtual ImageData* paintRenderingResultsToImageData(SourceDrawingBuffer) { A SSERT_NOT_REACHED(); return nullptr; } | 119 virtual ImageData* paintRenderingResultsToImageData(SourceDrawingBuffer) { A SSERT_NOT_REACHED(); return nullptr; } |
| 119 virtual int externallyAllocatedBytesPerPixel() { ASSERT_NOT_REACHED(); retur n 0; } | 120 virtual int externallyAllocatedBytesPerPixel() { ASSERT_NOT_REACHED(); retur n 0; } |
| 120 | 121 |
| 121 // ImageBitmap-specific interface | 122 // ImageBitmap-specific interface |
| 122 virtual bool paint(GraphicsContext&, const IntRect&) { return false; } | 123 virtual bool paint(GraphicsContext&, const IntRect&) { return false; } |
| 123 | 124 |
| 124 bool wouldTaintOrigin(CanvasImageSource*); | 125 bool wouldTaintOrigin(CanvasImageSource*); |
| 125 void didMoveToNewDocument(Document*); | 126 void didMoveToNewDocument(Document*); |
| 126 | 127 |
| 127 protected: | 128 protected: |
| 128 CanvasRenderingContext(HTMLCanvasElement*); | 129 CanvasRenderingContext(HTMLCanvasElement*); |
| 129 DECLARE_VIRTUAL_TRACE(); | 130 DECLARE_VIRTUAL_TRACE(); |
| 130 virtual void stop() = 0; | 131 virtual void stop() = 0; |
| 131 | 132 |
| 132 private: | 133 private: |
| 133 RawPtrWillBeMember<HTMLCanvasElement> m_canvas; | 134 RawPtrWillBeMember<HTMLCanvasElement> m_canvas; |
| 134 HashSet<String> m_cleanURLs; | 135 HashSet<String> m_cleanURLs; |
| 135 HashSet<String> m_dirtyURLs; | 136 HashSet<String> m_dirtyURLs; |
| 136 }; | 137 }; |
| 137 | 138 |
| 138 } // namespace blink | 139 } // namespace blink |
| 139 | 140 |
| 140 #endif | 141 #endif |
| OLD | NEW |
