Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Unified Diff: content/browser/frame_host/navigation_entry_impl.h

Issue 1814993002: Handle about:blank in the Origin Info Bubble better. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add and use {Get,Set}Origin in NavigationEntry. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_entry_impl.h
diff --git a/content/browser/frame_host/navigation_entry_impl.h b/content/browser/frame_host/navigation_entry_impl.h
index 5907b6c2bd5992a25d6671a20c1c8ad3582da799..e59601f82caafca0aebdf40e35e05e369e867264 100644
--- a/content/browser/frame_host/navigation_entry_impl.h
+++ b/content/browser/frame_host/navigation_entry_impl.h
@@ -21,6 +21,7 @@
#include "content/public/browser/navigation_entry.h"
#include "content/public/common/page_state.h"
#include "content/public/common/ssl_status.h"
+#include "url/origin.h"
namespace content {
struct CommonNavigationParams;
@@ -83,6 +84,8 @@ class CONTENT_EXPORT NavigationEntryImpl
PageType GetPageType() const override;
void SetURL(const GURL& url) override;
const GURL& GetURL() const override;
+ void SetOrigin(const url::Origin& origin) override;
+ const url::Origin& GetOrigin() const override;
void SetBaseURLForDataURL(const GURL& url) override;
const GURL& GetBaseURLForDataURL() const override;
#if defined(OS_ANDROID)
@@ -503,6 +506,9 @@ class CONTENT_EXPORT NavigationEntryImpl
// time (see TabNavigation for an example of this).
std::map<std::string, base::string16> extra_data_;
+ // The effective Origin at the time of commit.
+ url::Origin origin_;
Charlie Reis 2016/04/18 19:58:38 Please put this above browser_initiated_post_data_
palmer 2016/04/18 23:37:35 Done.
+
DISALLOW_COPY_AND_ASSIGN(NavigationEntryImpl);
};

Powered by Google App Engine
This is Rietveld 408576698