content/browser/frame_host/navigation_controller_impl.cc - Issue 1814993002: Handle about:blank in the Origin Info Bubble better.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 1814993002: Handle about:blank in the Origin Info Bubble better. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add and use {Get,Set}Origin in NavigationEntry. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/frame_navigation_entry.h ('K') | « content/browser/frame_host/frame_navigation_entry.h ('k') | content/browser/frame_host/navigation_entry_impl.h » ('j') | content/browser/frame_host/navigation_entry_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_controller_impl.cc

diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc

index 6732fefb8c17d6238449212d5b06b4a38c78dabd..6ae8e4739f17618dc09fc0dab9fe2155b0fafaee 100644

--- a/content/browser/frame_host/navigation_controller_impl.cc

+++ b/content/browser/frame_host/navigation_controller_impl.cc

@@ -1113,6 +1113,7 @@ void NavigationControllerImpl::RendererDidNavigateToNewPage(

new_entry->set_page_type(params.url_is_unreachable ? PAGE_TYPE_ERROR

: PAGE_TYPE_NORMAL);

new_entry->SetURL(params.url);

+ new_entry->SetOrigin(url::Origin(params.url));

if (update_virtual_url)

UpdateVirtualURLToURL(new_entry.get(), params.url);

new_entry->SetReferrer(params.referrer);

@@ -1180,6 +1181,7 @@ void NavigationControllerImpl::RendererDidNavigateToExistingPage(

entry->set_page_type(params.url_is_unreachable ? PAGE_TYPE_ERROR

: PAGE_TYPE_NORMAL);

entry->SetURL(params.url);

+ entry->SetOrigin(url::Origin(params.url));

entry->SetReferrer(params.referrer);

if (entry->update_virtual_url_with_url())

UpdateVirtualURLToURL(entry, params.url);

@@ -1238,6 +1240,7 @@ void NavigationControllerImpl::RendererDidNavigateToSamePage(

if (existing_entry->update_virtual_url_with_url())

UpdateVirtualURLToURL(existing_entry, params.url);

existing_entry->SetURL(params.url);

+ existing_entry->SetOrigin(url::Origin(params.url));

existing_entry->SetReferrer(params.referrer);

// The page may have been requested with a different HTTP method.