Convert filesystem_apptests to shelltests.

Convert filesystem_apptests to shelltests.

BUG=594730
Committed: https://crrev.com/716b6174dbd421bbec303657fdbf29069fe46ada
Cr-Commit-Position: refs/heads/master@{#382021}

[Elliot Glaysher, 2016-03-17 22:17:38]

erg@chromium.org changed reviewers:
+ yzshen@chromium.org

[Elliot Glaysher, 2016-03-17 22:17:38]

This is the patch with the weird shell test behaviour.

[yzshen1, 2016-03-17 22:56:57]

https://codereview.chromium.org/1814983002/diff/40001/mojo/shell/public/cpp/l...
File mojo/shell/public/cpp/lib/shell_test.cc (right):

https://codereview.chromium.org/1814983002/diff/40001/mojo/shell/public/cpp/l...
mojo/shell/public/cpp/lib/shell_test.cc:59: base::RunLoop run_loop;
I am personally fine with this, but not sure whether we want this behavior with
all shell tests. You might want to confirm with Ben.

[Elliot Glaysher, 2016-03-17 23:11:02]

erg@chromium.org changed reviewers:
+ ben@chromium.org

[Elliot Glaysher, 2016-03-17 23:11:03]

hi, ben@. yzshen@ was correct about what was causing the deadlock. do you think
this is ok?

[yzshen1, 2016-03-17 23:14:45]

On 2016/03/17 23:11:03, Elliot Glaysher wrote:
> hi, ben@. yzshen@ was correct about what was causing the deadlock. do you
think
> this is ok?

LGTM if Ben also thinks this is okay.

[Ben Goodger (Google), 2016-03-17 23:32:53]

lgtm

[Elliot Glaysher, 2016-03-18 17:27:37]

erg@chromium.org changed reviewers:
+ sky@chromium.org

[Elliot Glaysher, 2016-03-18 17:27:38]

+sky for testsing/buildbot/ changes.

[sky, 2016-03-18 17:32:54]

LGTM

[Elliot Glaysher, 2016-03-18 17:36:42]

The CQ bit was checked by erg@chromium.org

[Elliot Glaysher, 2016-03-18 17:36:42]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org,
ben@chromium.org
Link to the patchset: https://codereview.chromium.org/1814983002/#ps100001
(title: "Also delete references to the old apptests")

[commit-bot: I haz the power, 2016-03-18 17:36:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814983002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814983002/100001

[commit-bot: I haz the power, 2016-03-18 18:30:40]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-18 18:32:04]

Description was changed from

==========
Convert filesystem_apptests to shelltests.

BUG=594730
==========

to

==========
Convert filesystem_apptests to shelltests.

BUG=594730

Committed: https://crrev.com/716b6174dbd421bbec303657fdbf29069fe46ada
Cr-Commit-Position: refs/heads/master@{#382021}
==========

[commit-bot: I haz the power, 2016-03-18 18:32:05]

Patchset 6 (id:??) landed as
https://crrev.com/716b6174dbd421bbec303657fdbf29069fe46ada
Cr-Commit-Position: refs/heads/master@{#382021}