Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: components/filesystem/BUILD.gn

Issue 1814983002: Convert filesystem_apptests to shelltests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Also delete references to the old apptests Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | components/filesystem/apptest_manifest.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/filesystem/BUILD.gn
diff --git a/components/filesystem/BUILD.gn b/components/filesystem/BUILD.gn
index e09c1666937a3d4bdde0a4e18e1b37996a6e0c74..e941f31ece50326d325a60da53473df971165d33 100644
--- a/components/filesystem/BUILD.gn
+++ b/components/filesystem/BUILD.gn
@@ -4,6 +4,7 @@
import("//mojo/public/mojo_application.gni")
import("//mojo/public/mojo_application_manifest.gni")
+import("//testing/test.gni")
source_set("lib") {
sources = [
@@ -60,10 +61,8 @@ mojo_application_manifest("manifest") {
source = "manifest.json"
}
-mojo_native_application("apptests") {
- output_name = "filesystem_apptests"
-
- testonly = true
+test("unittests") {
+ output_name = "filesystem_service_unittests"
sources = [
"directory_impl_unittest.cc",
@@ -76,18 +75,21 @@ mojo_native_application("apptests") {
"//base",
"//components/filesystem/public/interfaces",
"//mojo/common",
- "//mojo/platform_handle:for_shared_library",
+ "//mojo/platform_handle",
"//mojo/public/cpp/bindings",
- "//mojo/shell/public/cpp:test_support",
+ "//mojo/shell/public/cpp:shell_test_support",
+ "//mojo/shell/public/cpp:sources",
+ "//mojo/shell/public/cpp/test:run_all_shelltests",
]
data_deps = [
- ":apptest_manifest",
+ ":test_manifest",
":filesystem",
]
}
-mojo_application_manifest("apptest_manifest") {
- application_name = "filesystem_apptests"
- source = "apptest_manifest.json"
+mojo_application_manifest("test_manifest") {
+ type = "exe"
+ application_name = "filesystem_service_unittests"
+ source = "test_manifest.json"
}
« no previous file with comments | « BUILD.gn ('k') | components/filesystem/apptest_manifest.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698