|
Nuke NotificationUIManager from PlatformNotificationServiceImpl
A few highlights
- Always use one kind of profile id (the stable one)
- Always use a single notification id (the persistent one when possible)
- The mac implementation injects the NSUSerNotificationService to allow unittests
Note that the mac and android files are not renamed. Ideally I would land this and then land a straight forward rename cl.
BUG= 571056, 596161
Committed: https://crrev.com/23cd2dd719c8e76e17e764100a6eff131c34a418
Cr-Commit-Position: refs/heads/master@{#388776}
Total comments: 24
Total comments: 54
Total comments: 16
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+665 lines, -324 lines) |
Patch |
|
M |
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java
|
View
|
1
2
3
4
5
6
7
8
|
2 chunks |
+6 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/android/chrome_jni_registrar.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/browser_process.h
|
View
|
1
2
3
4
5
6
7
8
|
2 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/browser_process_impl.h
|
View
|
1
2
3
4
5
6
7
8
|
3 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/browser_process_impl.cc
|
View
|
1
2
3
4
5
6
7
8
|
4 chunks |
+29 lines, -1 line |
0 comments
|
Download
|
|
A |
chrome/browser/notifications/message_center_display_service.h
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+37 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/browser/notifications/message_center_display_service.cc
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+40 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/browser/notifications/native_notification_display_service.h
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+40 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/browser/notifications/native_notification_display_service.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+55 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/browser/notifications/notification_display_service.h
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+48 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/browser/notifications/notification_display_service_factory.h
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+34 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/browser/notifications/notification_display_service_factory.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+68 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/browser/notifications/notification_platform_bridge.h
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+58 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/notifications/notification_ui_manager_android.h
|
View
|
1
2
3
4
5
6
7
8
|
2 chunks |
+24 lines, -27 lines |
0 comments
|
Download
|
|
M |
chrome/browser/notifications/notification_ui_manager_android.cc
|
View
|
1
2
3
4
5
6
7
8
|
5 chunks |
+30 lines, -63 lines |
0 comments
|
Download
|
|
M |
chrome/browser/notifications/notification_ui_manager_mac.h
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+21 lines, -26 lines |
0 comments
|
Download
|
|
M |
chrome/browser/notifications/notification_ui_manager_mac.mm
|
View
|
1
2
3
4
5
6
7
8
|
4 chunks |
+54 lines, -127 lines |
0 comments
|
Download
|
|
M |
chrome/browser/notifications/platform_notification_service_browsertest.cc
|
View
|
1
2
3
4
5
6
7
8
|
3 chunks |
+6 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/browser/notifications/platform_notification_service_impl.h
|
View
|
1
2
3
4
5
6
7
8
|
5 chunks |
+10 lines, -14 lines |
0 comments
|
Download
|
|
M |
chrome/browser/notifications/platform_notification_service_impl.cc
|
View
|
1
2
3
4
5
6
7
8
|
11 chunks |
+52 lines, -46 lines |
0 comments
|
Download
|
|
M |
chrome/browser/notifications/platform_notification_service_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
|
3 chunks |
+18 lines, -7 lines |
0 comments
|
Download
|
|
M |
chrome/browser/push_messaging/push_messaging_browsertest.cc
|
View
|
1
2
3
4
5
6
7
|
5 chunks |
+9 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_browser.gypi
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+8 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/test/base/testing_browser_process.h
|
View
|
1
2
3
4
5
6
7
8
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/test/base/testing_browser_process.cc
|
View
|
1
2
3
4
5
6
7
8
|
2 chunks |
+6 lines, -1 line |
0 comments
|
Download
|
Total messages: 26 (12 generated)
|