Nuke NotificationUIManager from PlatformNotificationServiceImpl

chrome/browser/notifications/platform_notification_service_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/platform_notification_service_impl.h"
 
 #include <utility>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/metrics/user_metrics_action.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
 #include "chrome/browser/notifications/desktop_notification_profile_util.h"
+#include "chrome/browser/notifications/notification_display_service_factory.h"
 #include "chrome/browser/notifications/notification_object_proxy.h"
 #include "chrome/browser/notifications/notification_ui_manager.h"
 #include "chrome/browser/notifications/persistent_notification_delegate.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_io_data.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/chrome_pages.h"
 #include "chrome/browser/ui/scoped_tabbed_browser_displayer.h"
 #include "chrome/common/chrome_switches.h"
@@ skipping 53 matching lines @@
 }
 
 void OnCloseEventDispatchComplete(
     content::PersistentNotificationStatus status) {
   UMA_HISTOGRAM_ENUMERATION(
       "Notifications.PersistentWebNotificationCloseResult", status,
       content::PersistentNotificationStatus::
           PERSISTENT_NOTIFICATION_STATUS_MAX);
 }
 
-void CancelNotification(const std::string& id, ProfileID profile_id) {
-  PlatformNotificationServiceImpl::GetInstance()
-      ->GetNotificationUIManager()->CancelById(id, profile_id);
+void OnCloseEphimeralNotificationProfileLoaded(
+    const std::string& notification_id,
+    Profile* profile) {
+  PlatformNotificationServiceImpl::GetInstance()->GetNotificationDisplayService(

[Peter Beverloo, 2016/04/18 14:57:10]

NotificationDisplayServiceFactory::GetForProfile(profile)->Close(notification_id);

[Miguel Garcia, 2016/04/21 14:32:10]

The follow up CL I noted does this.
https://codereview.chromium.org/1895473002

I cannot do it right now without changing the tests more which makes the CL
bigger unnecessarily

+      profile)
+      ->Close(notification_id);
 }
 
 // Callback to run once the profile has been loaded in order to perform a
 // given |operation| in a notification.
 void ProfileLoadedCallback(
     PlatformNotificationServiceImpl::NotificationOperation operation,
     const GURL& origin,
     int64_t persistent_notification_id,
     int action_index,
     Profile* profile) {
@@ skipping 15 matching lines @@
           ->OnPersistentNotificationClose(profile, persistent_notification_id,
                                           origin, true);
       break;
     case PlatformNotificationServiceImpl::NOTIFICATION_SETTINGS:
       PlatformNotificationServiceImpl::GetInstance()->OpenNotificationSettings(
           profile);
       break;
   }
 }
 
+// Callback used to close an ephimeral notification from blink.
+void CancelNotification(const std::string& notification_id,
+                        std::string profile_id,
+                        bool incognito) {
+  ProfileManager* profile_manager = g_browser_process->profile_manager();

[Peter Beverloo, 2016/04/18 14:57:10]

To confirm, we imagine all of this moving to the NotificationDisplayService,
right?

[Miguel Garcia, 2016/04/21 14:32:10]

Yes, once ids are generated in content.

+  DCHECK(profile_manager);
+  profile_manager->LoadProfile(
+      profile_id, incognito,
+      base::Bind(&OnCloseEphimeralNotificationProfileLoaded, notification_id));
+}
+
 }  // namespace
 
 // static
 PlatformNotificationServiceImpl*
 PlatformNotificationServiceImpl::GetInstance() {
   return base::Singleton<PlatformNotificationServiceImpl>::get();
 }
 
 PlatformNotificationServiceImpl::PlatformNotificationServiceImpl()
-    : native_notification_ui_manager_(
-          NotificationUIManager::CreateNativeNotificationManager()),
-      notification_ui_manager_for_tests_(nullptr) {}
+    : test_display_service_(nullptr) {}
 
 PlatformNotificationServiceImpl::~PlatformNotificationServiceImpl() {}
 
 void PlatformNotificationServiceImpl::ProcessPersistentNotificationOperation(
     NotificationOperation operation,
     const std::string& profile_id,
     bool incognito,
     const GURL& origin,
     int64_t persistent_notification_id,
     int action_index) {
@@ skipping 170 matching lines @@
 
   Profile* profile = Profile::FromBrowserContext(browser_context);
   DCHECK(profile);
   DCHECK_EQ(0u, notification_data.actions.size());
   DCHECK_EQ(0u, notification_resources.action_icons.size());
 
   NotificationObjectProxy* proxy =
       new NotificationObjectProxy(browser_context, std::move(delegate));
   Notification notification = CreateNotificationFromData(
       profile, origin, notification_data, notification_resources, proxy);
-
-  GetNotificationUIManager()->Add(notification, profile);
-  if (cancel_callback)
+  GetNotificationDisplayService(profile)->Display(notification.delegate_id(),
+                                                  notification);
+  if (cancel_callback) {
+#if defined(OS_WIN)
+    std::string profile_id =
+        base::WideToUTF8(profile->GetPath().BaseName().value());
+#elif defined(OS_POSIX)
+    std::string profile_id = profile->GetPath().BaseName().value();
+#endif
     *cancel_callback =
-        base::Bind(&CancelNotification,
-                   notification.delegate_id(),
-                   NotificationUIManager::GetProfileID(profile));
+        base::Bind(&CancelNotification, notification.delegate_id(), profile_id,
+                   profile->IsOffTheRecord());
+  }
 
   HostContentSettingsMapFactory::GetForProfile(profile)->UpdateLastUsage(
       origin, origin, CONTENT_SETTINGS_TYPE_NOTIFICATIONS);
 }
 
 void PlatformNotificationServiceImpl::DisplayPersistentNotification(
     BrowserContext* browser_context,
     int64_t persistent_notification_id,
     const GURL& origin,
     const content::PlatformNotificationData& notification_data,
@@ skipping 10 matching lines @@
       browser_context, persistent_notification_id, origin,
       settings_button_index);
 
   Notification notification = CreateNotificationFromData(
       profile, origin, notification_data, notification_resources, delegate);
 
   // TODO(peter): Remove this mapping when we have reliable id generation for
   // the message_center::Notification objects.
   persistent_notifications_[persistent_notification_id] = notification.id();
 
-  GetNotificationUIManager()->Add(notification, profile);
+  GetNotificationDisplayService(profile)->Display(
+      base::Int64ToString(delegate->persistent_notification_id()),
+      notification);
   content::RecordAction(
       base::UserMetricsAction("Notifications.Persistent.Shown"));
 
   HostContentSettingsMapFactory::GetForProfile(profile)->UpdateLastUsage(
       origin, origin, CONTENT_SETTINGS_TYPE_NOTIFICATIONS);
 }
 
 void PlatformNotificationServiceImpl::ClosePersistentNotification(
     BrowserContext* browser_context,
     int64_t persistent_notification_id) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
 
   Profile* profile = Profile::FromBrowserContext(browser_context);
   DCHECK(profile);
 
   closed_notifications_.insert(persistent_notification_id);
 
 #if defined(OS_ANDROID)
   bool cancel_by_persistent_id = true;
 #else
-  bool cancel_by_persistent_id = (native_notification_ui_manager_ != nullptr);
+  bool cancel_by_persistent_id =
+      GetNotificationDisplayService(profile)->SupportsNotificationCenter();
 #endif
 
   if (cancel_by_persistent_id) {
     // TODO(peter): Remove this conversion when the notification ids are being
     // generated by the caller of this method.
-    GetNotificationUIManager()->CancelById(
-        base::Int64ToString(persistent_notification_id),
-        NotificationUIManager::GetProfileID(profile));
+    GetNotificationDisplayService(profile)->Close(
+        base::Int64ToString(persistent_notification_id));
   }
 
   auto iter = persistent_notifications_.find(persistent_notification_id);
   if (iter == persistent_notifications_.end())
     return;
 
-  GetNotificationUIManager()->CancelById(
-      iter->second, NotificationUIManager::GetProfileID(profile));
+  GetNotificationDisplayService(profile)->Close(iter->second);
 
   persistent_notifications_.erase(iter);
 }
 
 bool PlatformNotificationServiceImpl::GetDisplayedPersistentNotifications(
     BrowserContext* browser_context,
     std::set<std::string>* displayed_notifications) {
   DCHECK(displayed_notifications);
 
-#if !defined(OS_ANDROID)
   Profile* profile = Profile::FromBrowserContext(browser_context);
   if (!profile || profile->AsTestingProfile())
     return false;  // Tests will not have a message center.
 
-  NotificationUIManager* ui_manager = GetNotificationUIManager();
-  DCHECK(ui_manager);
-
   // TODO(peter): Filter for persistent notifications only.
-  *displayed_notifications = ui_manager->GetAllIdsByProfile(
-      NotificationUIManager::GetProfileID(profile));
-
-  return true;
-#else
-  // Android cannot reliably return the notifications that are currently being
-  // displayed on the platform, see the comment in NotificationUIManagerAndroid.
-  return false;
-#endif  // !defined(OS_ANDROID)
+  return GetNotificationDisplayService(profile)->GetDisplayed(
+      displayed_notifications);
 }
 
 Notification PlatformNotificationServiceImpl::CreateNotificationFromData(
     Profile* profile,
     const GURL& origin,
     const content::PlatformNotificationData& notification_data,
     const content::NotificationResources& notification_resources,
     NotificationDelegate* delegate) const {
   DCHECK_EQ(notification_data.actions.size(),
             notification_resources.action_icons.size());
@@ skipping 34 matching lines @@
 
   // On desktop, notifications with require_interaction==true stay on-screen
   // rather than minimizing to the notification center after a timeout.
   // On mobile, this is ignored (notifications are minimized at all times).
   if (notification_data.require_interaction)
     notification.set_never_timeout(true);
 
   return notification;
 }
 
-NotificationUIManager*
-PlatformNotificationServiceImpl::GetNotificationUIManager() const {
-  if (notification_ui_manager_for_tests_)
-    return notification_ui_manager_for_tests_;
-
-  if (native_notification_ui_manager_) {
-    return native_notification_ui_manager_.get();
-  }
-
-  return g_browser_process->notification_ui_manager();
+NotificationDisplayService*
+PlatformNotificationServiceImpl::GetNotificationDisplayService(
+    Profile* profile) {
+  if (test_display_service_ != nullptr)
+    return test_display_service_;
+  return NotificationDisplayServiceFactory::GetForProfile(profile);
 }
 
 void PlatformNotificationServiceImpl::OpenNotificationSettings(
     BrowserContext* browser_context) {
 #if defined(OS_ANDROID)
   NOTIMPLEMENTED();
 #else
 
   Profile* profile = Profile::FromBrowserContext(browser_context);
   DCHECK(profile);
 
   if (switches::SettingsWindowEnabled()) {
     chrome::ShowContentSettingsExceptionsInWindow(
         profile, CONTENT_SETTINGS_TYPE_NOTIFICATIONS);
   } else {
     chrome::ScopedTabbedBrowserDisplayer browser_displayer(profile);
     chrome::ShowContentSettingsExceptions(browser_displayer.browser(),
                                           CONTENT_SETTINGS_TYPE_NOTIFICATIONS);
   }
 
 #endif  // defined(OS_ANDROID)
 }
 
-void PlatformNotificationServiceImpl::SetNotificationUIManagerForTesting(
-    NotificationUIManager* manager) {
-  notification_ui_manager_for_tests_ = manager;
-}
-
 base::string16 PlatformNotificationServiceImpl::DisplayNameForContextMessage(
     Profile* profile,
     const GURL& origin) const {
 #if defined(ENABLE_EXTENSIONS)
   // If the source is an extension, lookup the display name.
   if (origin.SchemeIs(extensions::kExtensionScheme)) {
     const extensions::Extension* extension =
         extensions::ExtensionRegistry::Get(profile)->GetExtensionById(
             origin.host(), extensions::ExtensionRegistry::EVERYTHING);
     DCHECK(extension);
 
     return base::UTF8ToUTF16(extension->name());
   }
 #endif
 
   return base::string16();
 }
+
+void PlatformNotificationServiceImpl::SetNotificationDisplayServiceForTesting(
+    NotificationDisplayService* display_service) {
+  test_display_service_ = display_service;
+}