Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.cc

Issue 1814863002: Make page popups work under OOPIF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: WebContentsImpl::SendScreenRects simplified Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_widget_host_view_child_frame.cc
diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.cc b/content/browser/frame_host/render_widget_host_view_child_frame.cc
index 7c60d9c1126d8c62a45720fb220c2f4b111bd7f1..71318cf7dfafcabf01057604013e67ee361f148d 100644
--- a/content/browser/frame_host/render_widget_host_view_child_frame.cc
+++ b/content/browser/frame_host/render_widget_host_view_child_frame.cc
@@ -68,6 +68,11 @@ void RenderWidgetHostViewChildFrame::SetSize(const gfx::Size& size) {
void RenderWidgetHostViewChildFrame::SetBounds(const gfx::Rect& rect) {
SetSize(rect.size());
+
+ if (rect != last_screen_rect_) {
+ last_screen_rect_ = rect;
+ host_->SendScreenRects();
+ }
lfg 2016/03/18 15:46:00 I don't think this is enough, we need to send the
kenrb 2016/03/18 17:46:10 I don't think I understand this. This should be ca
lfg 2016/03/18 18:53:53 Let's say you have a FrameTree like: A | B | C
kenrb 2016/03/18 20:03:19 This is a really good point, thanks for catching i
lfg 2016/03/18 20:06:20 Sounds good. lgtm.
}
void RenderWidgetHostViewChildFrame::Focus() {

Powered by Google App Engine
This is Rietveld 408576698