Make page popups work under OOPIF

content/browser/frame_host/render_widget_host_view_child_frame.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_widget_host_view_child_frame.h"
 
 #include <algorithm>
 #include <utility>
 #include <vector>
 
@@ skipping 50 matching lines @@
 RenderWidgetHost* RenderWidgetHostViewChildFrame::GetRenderWidgetHost() const {
   return host_;
 }
 
 void RenderWidgetHostViewChildFrame::SetSize(const gfx::Size& size) {
   host_->WasResized();
 }
 
 void RenderWidgetHostViewChildFrame::SetBounds(const gfx::Rect& rect) {
   SetSize(rect.size());
+
+  if (rect != last_screen_rect_) {
+    last_screen_rect_ = rect;
+    host_->SendScreenRects();
+  }

[lfg, 2016/03/18 15:46:00]

I don't think this is enough, we need to send the screen rects to all the
descendant local roots in the frame tree.

[kenrb, 2016/03/18 17:46:10]

I don't think I understand this. This should be called independently for each
local root, since each CrossProcessFrameConnector should get an IPC with the
rect in it.

[lfg, 2016/03/18 18:53:53]

Let's say you have a FrameTree like:

A
 |
B
 |
C

If in the renderer for A the position of B is changed, we should get an IPC for
the change in the frame rect. However, the location of C also changed, but I
don't think renderer B will send an IPC for the location change.

[kenrb, 2016/03/18 20:03:19]

This is a really good point, thanks for catching it. Given time constraints, I
am going to propose that (if this is the only issue), this CL goes in as is and
I will file a bug to fix next week.

[lfg, 2016/03/18 20:06:20]

Sounds good. lgtm.

 }
 
 void RenderWidgetHostViewChildFrame::Focus() {
 }
 
 bool RenderWidgetHostViewChildFrame::HasFocus() const {
   if (frame_connector_)
     return frame_connector_->HasFocus();
   return false;
 }
@@ skipping 496 matching lines @@
   if (surface_factory_ && !surface_id_.is_null())
     surface_factory_->Destroy(surface_id_);
   surface_id_ = cc::SurfaceId();
 }
 
 cc::SurfaceId RenderWidgetHostViewChildFrame::SurfaceIdForTesting() const {
   return surface_id_;
 };
 
 }  // namespace content