Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1814853006: MediaRecorder: Tune complexity settings for VP9 encoding (Closed)

Created:
4 years, 9 months ago by mcasas
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

MediaRecorder: Tune complexity settings for VP9 encoding The first landing on this branch got reverted due to a silly mistake: it needed a previous CL (the first go). Now both are considered below. --- description for the second CL ----------------------------- This code was landed but -silly me- I was setting the complexity _before_ creating the encoder :P Also, the values the VP8E_SET_CPUUSED parameter are: - up to 8 for VP9 (and not up to 16, that's for VP8) - Real Time values are 5 - 8 [1] BUG=591342, 589162 [1] https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc&sq=package:chromium&type=cs&l=35&rcl=1458143321 --- description for the first CL ------------------------------ Review URL: https://codereview.chromium.org/1809853002 Cr-Commit-Position: refs/heads/master@{#381572} VideoTrackRecorder: limit VP9 cpu usage and quality Also this CL simplifies the way VideoTrackRecorderTests deals with the expectations, in the same way as MediaRecorderHandlerTest was simplified before in https://codereview.chromium.org/1579693006 BUG=589162 Review URL: https://codereview.chromium.org/1732083002 Cr-Commit-Position: refs/heads/master@{#378085} TBR=niklase@chromium.org NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M content/renderer/media/video_track_recorder.cc View 2 chunks +13 lines, -3 lines 0 comments Download
M content/renderer/media/video_track_recorder_unittest.cc View 3 chunks +8 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1814853006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1814853006/1
4 years, 9 months ago (2016-03-18 16:49:44 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 16:51:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698