Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1809853002: MediaRecorder: Tune complexity settings for VP9 encoding (second go) (Closed)

Created:
4 years, 9 months ago by mcasas
Modified:
4 years, 9 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MediaRecorder: Tune complexity settings for VP9 encoding (second go) This code was landed but -silly me- I was setting the complexity _before_ creating the encoder :P Also, the values the VP8E_SET_CPUUSED parameter are: - up to 8 for VP9 (and not up to 16, that's for VP8) - Real Time values are 5 - 8 [1] BUG=591342, 589162 [1] https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc&sq=package:chromium&type=cs&l=35&rcl=1458143321 Committed: https://crrev.com/4e1da39cc90c4a335bb1fa777c7ab25f50d8f22f Cr-Commit-Position: refs/heads/master@{#381572}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M content/renderer/media/video_track_recorder.cc View 2 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
mcasas
niklase@, marpan@ PTAL
4 years, 9 months ago (2016-03-16 21:41:47 UTC) #2
marpan
lgtm
4 years, 9 months ago (2016-03-16 21:56:12 UTC) #4
mcasas
4 years, 9 months ago (2016-03-16 22:31:25 UTC) #6
Niklas Enbom
lgtm On 2016/03/16 22:31:25, mcasas wrote:
4 years, 9 months ago (2016-03-16 22:33:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809853002/1
4 years, 9 months ago (2016-03-16 22:35:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 22:53:05 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 22:54:57 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e1da39cc90c4a335bb1fa777c7ab25f50d8f22f
Cr-Commit-Position: refs/heads/master@{#381572}

Powered by Google App Engine
This is Rietveld 408576698