third_party/WebKit/Source/core/dom/ScriptLoader.cpp - Issue 1814853003: Track whether an element was inserted via document.write

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ScriptLoader.cpp

Issue 1814853003: Track whether an element was inserted via document.write (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/ScriptLoader.h ('K') | « third_party/WebKit/Source/core/dom/ScriptLoader.h ('k') | third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp » ('j') | third_party/WebKit/Source/core/html/HTMLScriptElement.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/ScriptLoader.cpp

diff --git a/third_party/WebKit/Source/core/dom/ScriptLoader.cpp b/third_party/WebKit/Source/core/dom/ScriptLoader.cpp

index b33f34f19aa2891a85c1daa62870e688f9a8b4e0..408754f35bc06423b5e3ae50d9352eacd5791692 100644

--- a/third_party/WebKit/Source/core/dom/ScriptLoader.cpp

+++ b/third_party/WebKit/Source/core/dom/ScriptLoader.cpp

@@ -57,7 +57,7 @@

namespace blink {

-ScriptLoader::ScriptLoader(Element* element, bool parserInserted, bool alreadyStarted)

+ScriptLoader::ScriptLoader(Element* element, bool parserInserted, bool alreadyStarted, bool createdDuringDocumentWrite)

: m_element(element)

, m_startLineNumber(WTF::OrdinalNumber::beforeFirst())

, m_parserInserted(parserInserted)

@@ -69,6 +69,7 @@ ScriptLoader::ScriptLoader(Element* element, bool parserInserted, bool alreadySt

, m_willExecuteInOrder(false)

, m_willExecuteWhenDocumentFinishedParsing(false)

, m_forceAsync(!parserInserted)

+ , m_createdDuringDocumentWrite(createdDuringDocumentWrite)

{

ASSERT(m_element);

if (parserInserted && element->document().scriptableDocumentParser() && !element->document().isInDocumentWrite())